[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Re: Review Request: Add a Plasma::Slider widget
From:       "Aaron J. Seigo" <aseigo () kde ! org>
Date:       2008-07-28 22:25:21
Message-ID: 200807281625.22040.aseigo () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Monday 28 July 2008, Alex Merry wrote:
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://reviewboard.vidsolbach.de/r/115/
> -----------------------------------------------------------
>
> Review request for Plasma.
>
>
> Summary
> -------
>
> Wraps the QSlider widget.
>
> Design decisions (or what I left out):
>
> Didn't bother with any of the "inverted" stuff, stepping or
> enabling/disabling tracking. Also, no simulating user interaction with the
> slider (setSliderDown(), etc). No action interface
> No rangeChanged() signal (since the user can't change it directly)
> No tick interface, but that can be added later if there's need
> Made setMinimum() and setMaximum() slots, since I have an immediate use for
> setMaximum as a slot.
>
>
> Diffs
> -----
>
>   KDE/kdebase/workspace/libs/plasma/CMakeLists.txt
>   KDE/kdebase/workspace/libs/plasma/includes/Slider
>   KDE/kdebase/workspace/libs/plasma/widgets/slider.h
>   KDE/kdebase/workspace/libs/plasma/widgets/slider.cpp
>
> Diff: http://reviewboard.vidsolbach.de/r/115/diff

hrm.. review-board seems broken, or at least this patch upload is =((

do you want to post the slider.h here?

> Added sliders to the nowplaying applet actually do something when dragged.

neat.

-- 
Aaron J. Seigo
humru othro a kohnu se
GPG Fingerprint: 8B8B 2209 0C6F 7C47 B1EA  EE75 D6B7 2EB1 A7F1 DB43

KDE core developer sponsored by Trolltech


["signature.asc" (application/pgp-signature)]

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]