[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-panel-devel
Subject:    Review Request: Add a Plasma::Slider widget
From:       "Alex Merry" <huntedhacker () tiscali ! co ! uk>
Date:       2008-07-28 21:41:53
Message-ID: 20080728214153.29587.20991 () vidsolbach ! de
[Download RAW message or body]


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://reviewboard.vidsolbach.de/r/115/
-----------------------------------------------------------

Review request for Plasma.


Summary
-------

Wraps the QSlider widget.

Design decisions (or what I left out):

Didn't bother with any of the "inverted" stuff, stepping or enabling/disabling \
tracking. Also, no simulating user interaction with the slider (setSliderDown(), \
etc). No action interface
No rangeChanged() signal (since the user can't change it directly)
No tick interface, but that can be added later if there's need
Made setMinimum() and setMaximum() slots, since I have an immediate use for \
setMaximum as a slot.


Diffs
-----

  KDE/kdebase/workspace/libs/plasma/CMakeLists.txt
  KDE/kdebase/workspace/libs/plasma/includes/Slider
  KDE/kdebase/workspace/libs/plasma/widgets/slider.h
  KDE/kdebase/workspace/libs/plasma/widgets/slider.cpp

Diff: http://reviewboard.vidsolbach.de/r/115/diff


Testing
-------

Added sliders to the nowplaying applet actually do something when dragged.

The only issue I found was that I get a bunch of "QPainter::begin: Cannot paint on a \
null pixmap" messages.


Thanks,

Alex

_______________________________________________
Plasma-devel mailing list
Plasma-devel@kde.org
https://mail.kde.org/mailman/listinfo/plasma-devel


[prev in list] [next in list] [prev in thread] [next in thread]