[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: [Calligra] eb493aa check whether the image wsp is valid
From:       Sven Langkamp <sven.langkamp () gmail ! com>
Date:       2011-01-05 11:48:33
Message-ID: AANLkTi=49Bawbh557S2mBJ8sLFe27KMLAJ9X0z3ZkBPB () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Wed, Jan 5, 2011 at 12:43 PM, Boudewijn Rempt <boud@valdyas.org> wrote:

> On Wednesday 05 January 2011, Sven Langkamp wrote:
> > On Wed, Jan 5, 2011 at 10:41 AM, Boudewijn Rempt <boud@valdyas.org>
> wrote:
> >
> > > commit eb493aa2b562b0a384899b2327501ac058171aaf
> > > branch master
> > > Author: Boudewijn Rempt <boud@valdyas.org>
> > > Date:   Wed Jan 5 10:36:19 2011 +0100
> > >
> > >    check whether the image wsp is valid
> > >
> > >    We should check whether a weak shared pointer is valid, instead
> > >    of checking the pointer -- which isn't set to 0 after the
> corresponding
> > >    shared pointer is deleted.
> > >
> > >    Should be backported to 2.3.
> > >
> > >    CCMAIL:kimageshop@kde.org <CCMAIL%3Akimageshop@kde.org> <
> CCMAIL%3Akimageshop@kde.org <CCMAIL%253Akimageshop@kde.org>>
> > >
> > >    BUG:261940
> > >
> >
> > I don't think that this is the complete fix. The problem indicates that
> > there is an old layer from a now invalid image still around.
>
> I've got some more patches I just committed -- that should make it both
> safe and clean.
>

Shouldn't it also clear the node and layer managers? Can't check that right
now.

[Attachment #5 (text/html)]

<div class="gmail_quote">On Wed, Jan 5, 2011 at 12:43 PM, Boudewijn Rempt <span \
dir="ltr">&lt;<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="border-left: 1px solid rgb(204, 204, \
204); margin: 0pt 0pt 0pt 0.8ex; padding-left: 1ex;"> <div class="im">On Wednesday 05 \
January 2011, Sven Langkamp wrote:<br> &gt; On Wed, Jan 5, 2011 at 10:41 AM, \
Boudewijn Rempt &lt;<a href="mailto:boud@valdyas.org">boud@valdyas.org</a>&gt; \
wrote:<br> &gt;<br>
&gt; &gt; commit eb493aa2b562b0a384899b2327501ac058171aaf<br>
&gt; &gt; branch master<br>
&gt; &gt; Author: Boudewijn Rempt &lt;<a \
href="mailto:boud@valdyas.org">boud@valdyas.org</a>&gt;<br> &gt; &gt; Date:   Wed Jan \
5 10:36:19 2011 +0100<br> &gt; &gt;<br>
&gt; &gt;    check whether the image wsp is valid<br>
&gt; &gt;<br>
&gt; &gt;    We should check whether a weak shared pointer is valid, instead<br>
&gt; &gt;    of checking the pointer -- which isn&#39;t set to 0 after the \
corresponding<br> &gt; &gt;    shared pointer is deleted.<br>
&gt; &gt;<br>
&gt; &gt;    Should be backported to 2.3.<br>
&gt; &gt;<br>
</div>&gt; &gt;    <a \
href="mailto:CCMAIL%3Akimageshop@kde.org">CCMAIL:kimageshop@kde.org</a> &lt;<a \
href="mailto:CCMAIL%253Akimageshop@kde.org">CCMAIL%3Akimageshop@kde.org</a>&gt;<br> \
<div class="im">&gt; &gt;<br> &gt; &gt;    BUG:261940<br>
&gt; &gt;<br>
&gt;<br>
&gt; I don&#39;t think that this is the complete fix. The problem indicates that<br>
&gt; there is an old layer from a now invalid image still around.<br>
<br>
</div>I&#39;ve got some more patches I just committed -- that should make it both \
safe and clean.<br></blockquote><div><br>Shouldn&#39;t it also clear the node and \
layer managers? Can&#39;t check that right now. <br></div> </div>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]