From kde-kimageshop Wed Jan 05 11:48:33 2011 From: Sven Langkamp Date: Wed, 05 Jan 2011 11:48:33 +0000 To: kde-kimageshop Subject: Re: [Calligra] eb493aa check whether the image wsp is valid Message-Id: X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=129422814602593 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1065163000==" --===============1065163000== Content-Type: multipart/alternative; boundary=0016363b804cf39985049917f656 --0016363b804cf39985049917f656 Content-Type: text/plain; charset=ISO-8859-1 On Wed, Jan 5, 2011 at 12:43 PM, Boudewijn Rempt wrote: > On Wednesday 05 January 2011, Sven Langkamp wrote: > > On Wed, Jan 5, 2011 at 10:41 AM, Boudewijn Rempt > wrote: > > > > > commit eb493aa2b562b0a384899b2327501ac058171aaf > > > branch master > > > Author: Boudewijn Rempt > > > Date: Wed Jan 5 10:36:19 2011 +0100 > > > > > > check whether the image wsp is valid > > > > > > We should check whether a weak shared pointer is valid, instead > > > of checking the pointer -- which isn't set to 0 after the > corresponding > > > shared pointer is deleted. > > > > > > Should be backported to 2.3. > > > > > > CCMAIL:kimageshop@kde.org < > CCMAIL%3Akimageshop@kde.org > > > > > > > BUG:261940 > > > > > > > I don't think that this is the complete fix. The problem indicates that > > there is an old layer from a now invalid image still around. > > I've got some more patches I just committed -- that should make it both > safe and clean. > Shouldn't it also clear the node and layer managers? Can't check that right now. --0016363b804cf39985049917f656 Content-Type: text/html; charset=ISO-8859-1 Content-Transfer-Encoding: quoted-printable
On Wed, Jan 5, 2011 at 12:43 PM, Boudewijn Rempt= <boud@valdyas.org= > wrote:
On Wednesday 05 January 2011, Sven Langkamp wrote:
> On Wed, Jan 5, 2011 at 10:41 AM, Boudewijn Rempt <boud@valdyas.org> wrote:
>
> > commit eb493aa2b562b0a384899b2327501ac058171aaf
> > branch master
> > Author: Boudewijn Rempt <b= oud@valdyas.org>
> > Date: =A0 Wed Jan 5 10:36:19 2011 +0100
> >
> > =A0 =A0check whether the image wsp is valid
> >
> > =A0 =A0We should check whether a weak shared pointer is valid, in= stead
> > =A0 =A0of checking the pointer -- which isn't set to 0 after = the corresponding
> > =A0 =A0shared pointer is deleted.
> >
> > =A0 =A0Should be backported to 2.3.
> >
> > =A0 =A0CCMAI= L:kimageshop@kde.org <CCMAIL%3Akimageshop@kde.org>
> >
> > =A0 =A0BUG:261940
> >
>
> I don't think that this is the complete fix. The problem indicates= that
> there is an old layer from a now invalid image still around.

I've got some more patches I just committed -- that should make i= t both safe and clean.

Shouldn't it also clear= the node and layer managers? Can't check that right now.
--0016363b804cf39985049917f656-- --===============1065163000== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kimageshop mailing list kimageshop@kde.org https://mail.kde.org/mailman/listinfo/kimageshop --===============1065163000==--