[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: [Calligra] eb493aa check whether the image wsp is valid
From:       Boudewijn Rempt <boud () valdyas ! org>
Date:       2011-01-05 11:43:03
Message-ID: 201101051243.03223.boud () valdyas ! org
[Download RAW message or body]

On Wednesday 05 January 2011, Sven Langkamp wrote:
> On Wed, Jan 5, 2011 at 10:41 AM, Boudewijn Rempt <boud@valdyas.org> wrote:
> 
> > commit eb493aa2b562b0a384899b2327501ac058171aaf
> > branch master
> > Author: Boudewijn Rempt <boud@valdyas.org>
> > Date:   Wed Jan 5 10:36:19 2011 +0100
> >
> >    check whether the image wsp is valid
> >
> >    We should check whether a weak shared pointer is valid, instead
> >    of checking the pointer -- which isn't set to 0 after the corresponding
> >    shared pointer is deleted.
> >
> >    Should be backported to 2.3.
> >
> >    CCMAIL:kimageshop@kde.org <CCMAIL%3Akimageshop@kde.org>
> >
> >    BUG:261940
> >
> 
> I don't think that this is the complete fix. The problem indicates that
> there is an old layer from a now invalid image still around.

I've got some more patches I just committed -- that should make it both safe and clean.

-- 
Boudewijn Rempt | http://www.valdyas.org, http://www.krita.org
_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop
[prev in list] [next in list] [prev in thread] [next in thread]