[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: [Calligra] eb493aa check whether the image wsp is valid
From:       Sven Langkamp <sven.langkamp () gmail ! com>
Date:       2011-01-05 11:40:52
Message-ID: AANLkTik4xKpVL9Wjn28vGn7077K-ZPgv5csxE1-z5__5 () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Wed, Jan 5, 2011 at 10:41 AM, Boudewijn Rempt <boud@valdyas.org> wrote:

> commit eb493aa2b562b0a384899b2327501ac058171aaf
> branch master
> Author: Boudewijn Rempt <boud@valdyas.org>
> Date:   Wed Jan 5 10:36:19 2011 +0100
>
>    check whether the image wsp is valid
>
>    We should check whether a weak shared pointer is valid, instead
>    of checking the pointer -- which isn't set to 0 after the corresponding
>    shared pointer is deleted.
>
>    Should be backported to 2.3.
>
>    CCMAIL:kimageshop@kde.org <CCMAIL%3Akimageshop@kde.org>
>
>    BUG:261940
>

I don't think that this is the complete fix. The problem indicates that
there is an old layer from a now invalid image still around.

[Attachment #5 (text/html)]

<div class="gmail_quote">On Wed, Jan 5, 2011 at 10:41 AM, Boudewijn Rempt <span \
dir="ltr">&lt;<a href="mailto:boud@valdyas.org" \
target="_blank">boud@valdyas.org</a>&gt;</span> wrote:<br><blockquote \
class="gmail_quote" style="border-left: 1px solid rgb(204, 204, 204); margin: 0pt 0pt \
0pt 0.8ex; padding-left: 1ex;">

commit eb493aa2b562b0a384899b2327501ac058171aaf<br>
branch master<br>
Author: Boudewijn Rempt &lt;<a href="mailto:boud@valdyas.org" \
                target="_blank">boud@valdyas.org</a>&gt;<br>
Date:   Wed Jan 5 10:36:19 2011 +0100<br>
<br>
    check whether the image wsp is valid<br>
<br>
    We should check whether a weak shared pointer is valid, instead<br>
    of checking the pointer -- which isn&#39;t set to 0 after the corresponding<br>
    shared pointer is deleted.<br>
<br>
    Should be backported to 2.3.<br>
<br>
    <a href="mailto:CCMAIL%3Akimageshop@kde.org" \
target="_blank">CCMAIL:kimageshop@kde.org</a><br> <br>
    BUG:261940<br></blockquote><div><br>I don&#39;t think that this is the complete \
fix. The problem indicates that there is an old layer from a now invalid image still \
around.<br></div></div>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]