[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-kimageshop
Subject:    Re: Mypaint paintop branch
From:       Sven Langkamp <sven.langkamp () gmail ! com>
Date:       2011-01-03 0:39:12
Message-ID: AANLkTi=YxE81TogAVcg3b4+hpToKK7ErQ7tBxphudqep () mail ! gmail ! com
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]


On Thu, Dec 30, 2010 at 3:23 PM, Martin Renold <martinxyz@gmx.ch> wrote:

> On Tue, Dec 28, 2010 at 02:59:36AM +0100, Sven Langkamp wrote:
> >
> > I tried that but the brush did assert on loading. I have now updated the
> > code to MyPaint 0.9, but most the recent brushes don't work correctly. I
> > only changed the isfinite and passed a default tilt, the rest is same as
> > before.
>
> Brush settings are mixed up. This will help:
>
> --- a/krita/plugins/paintops/mypaint/mypaint_brush_resource.cpp
> +++ b/krita/plugins/paintops/mypaint/mypaint_brush_resource.cpp
> @@ -198,6 +198,11 @@ public:
>             dict[def->cname] = def;
>             def->index = i++;
>         }
> +        //assert(i == BRUSH_SETTINGS_COUNT);
> +        if (i != BRUSH_SETTINGS_COUNT) {
> +          printf("Doh, you forgot a brush setting!\n");
> +          abort();
> +        }
>     }
>
>  };
>

Thanks, that helped a lot.

[Attachment #5 (text/html)]

<div class="gmail_quote">On Thu, Dec 30, 2010 at 3:23 PM, Martin Renold <span \
dir="ltr">&lt;<a href="mailto:martinxyz@gmx.ch">martinxyz@gmx.ch</a>&gt;</span> \
wrote:<br><blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt 0.8ex; \
border-left: 1px solid rgb(204, 204, 204); padding-left: 1ex;"> <div class="im">On \
Tue, Dec 28, 2010 at 02:59:36AM +0100, Sven Langkamp wrote:<br> &gt;<br>
&gt; I tried that but the brush did assert on loading. I have now updated the<br>
&gt; code to MyPaint 0.9, but most the recent brushes don&#39;t work correctly. I<br>
&gt; only changed the isfinite and passed a default tilt, the rest is same as<br>
&gt; before.<br>
<br>
</div>Brush settings are mixed up. This will help:<br>
<br>
--- a/krita/plugins/paintops/mypaint/mypaint_brush_resource.cpp<br>
+++ b/krita/plugins/paintops/mypaint/mypaint_brush_resource.cpp<br>
@@ -198,6 +198,11 @@ public:<br>
             dict[def-&gt;cname] = def;<br>
             def-&gt;index = i++;<br>
         }<br>
+        //assert(i == BRUSH_SETTINGS_COUNT);<br>
+        if (i != BRUSH_SETTINGS_COUNT) {<br>
+          printf(&quot;Doh, you forgot a brush setting!\n&quot;);<br>
+          abort();<br>
+        }<br>
     }<br>
<br>
 };<br></blockquote><div><br>Thanks, that helped a lot. <br></div></div>



_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop


[prev in list] [next in list] [prev in thread] [next in thread]