From kde-kimageshop  Mon Jan 03 00:39:12 2011
From: Sven Langkamp <sven.langkamp () gmail ! com>
Date: Mon, 03 Jan 2011 00:39:12 +0000
To: kde-kimageshop
Subject: Re: Mypaint paintop branch
Message-Id: <AANLkTi=YxE81TogAVcg3b4+hpToKK7ErQ7tBxphudqep () mail ! gmail ! com>
X-MARC-Message: https://marc.info/?l=kde-kimageshop&m=129401520920043
MIME-Version: 1
Content-Type: multipart/mixed; boundary="--===============1097578506=="

--===============1097578506==
Content-Type: multipart/alternative; boundary=0016363b845c7c66580498e66165

--0016363b845c7c66580498e66165
Content-Type: text/plain; charset=ISO-8859-1

On Thu, Dec 30, 2010 at 3:23 PM, Martin Renold <martinxyz@gmx.ch> wrote:

> On Tue, Dec 28, 2010 at 02:59:36AM +0100, Sven Langkamp wrote:
> >
> > I tried that but the brush did assert on loading. I have now updated the
> > code to MyPaint 0.9, but most the recent brushes don't work correctly. I
> > only changed the isfinite and passed a default tilt, the rest is same as
> > before.
>
> Brush settings are mixed up. This will help:
>
> --- a/krita/plugins/paintops/mypaint/mypaint_brush_resource.cpp
> +++ b/krita/plugins/paintops/mypaint/mypaint_brush_resource.cpp
> @@ -198,6 +198,11 @@ public:
>             dict[def->cname] = def;
>             def->index = i++;
>         }
> +        //assert(i == BRUSH_SETTINGS_COUNT);
> +        if (i != BRUSH_SETTINGS_COUNT) {
> +          printf("Doh, you forgot a brush setting!\n");
> +          abort();
> +        }
>     }
>
>  };
>

Thanks, that helped a lot.

--0016363b845c7c66580498e66165
Content-Type: text/html; charset=ISO-8859-1
Content-Transfer-Encoding: quoted-printable

<div class=3D"gmail_quote">On Thu, Dec 30, 2010 at 3:23 PM, Martin Renold <=
span dir=3D"ltr">&lt;<a href=3D"mailto:martinxyz@gmx.ch">martinxyz@gmx.ch</=
a>&gt;</span> wrote:<br><blockquote class=3D"gmail_quote" style=3D"margin: =
0pt 0pt 0pt 0.8ex; border-left: 1px solid rgb(204, 204, 204); padding-left:=
 1ex;">
<div class=3D"im">On Tue, Dec 28, 2010 at 02:59:36AM +0100, Sven Langkamp w=
rote:<br>
&gt;<br>
&gt; I tried that but the brush did assert on loading. I have now updated t=
he<br>
&gt; code to MyPaint 0.9, but most the recent brushes don&#39;t work correc=
tly. I<br>
&gt; only changed the isfinite and passed a default tilt, the rest is same =
as<br>
&gt; before.<br>
<br>
</div>Brush settings are mixed up. This will help:<br>
<br>
--- a/krita/plugins/paintops/mypaint/mypaint_brush_resource.cpp<br>
+++ b/krita/plugins/paintops/mypaint/mypaint_brush_resource.cpp<br>
@@ -198,6 +198,11 @@ public:<br>
 =A0 =A0 =A0 =A0 =A0 =A0 dict[def-&gt;cname] =3D def;<br>
 =A0 =A0 =A0 =A0 =A0 =A0 def-&gt;index =3D i++;<br>
 =A0 =A0 =A0 =A0 }<br>
+ =A0 =A0 =A0 =A0//assert(i =3D=3D BRUSH_SETTINGS_COUNT);<br>
+ =A0 =A0 =A0 =A0if (i !=3D BRUSH_SETTINGS_COUNT) {<br>
+ =A0 =A0 =A0 =A0 =A0printf(&quot;Doh, you forgot a brush setting!\n&quot;)=
;<br>
+ =A0 =A0 =A0 =A0 =A0abort();<br>
+ =A0 =A0 =A0 =A0}<br>
 =A0 =A0 }<br>
<br>
=A0};<br></blockquote><div><br>Thanks, that helped a lot. <br></div></div>

--0016363b845c7c66580498e66165--

--===============1097578506==
Content-Type: text/plain; charset="us-ascii"
MIME-Version: 1.0
Content-Transfer-Encoding: 7bit
Content-Disposition: inline

_______________________________________________
kimageshop mailing list
kimageshop@kde.org
https://mail.kde.org/mailman/listinfo/kimageshop

--===============1097578506==--