[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: D16749: Various grammar and capitalization fixes for UI consistency
From: Albert Astals Cid <noreply () phabricator ! kde ! org>
Date: 2018-11-08 18:32:47
Message-ID: 45f009674d18091aef1f343927821c6a () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
aacid added inline comments.
INLINE COMMENTS
> keyboard_layout.cpp:196
> // layout name is translated in the action name in keyboard kcm!
> - const QString action = QStringLiteral("Switch keyboard layout to \
> %1").arg(translatedLayout(it.value())); + const QString action = \
> QStringLiteral("Switch Keyboard Layout to %1").arg(translatedLayout(it.value())); \
> const auto shortcuts = KGlobalAccel::self()->globalShortcut(componentName, action);
Have you tested this? Because you're breaking things with this change.
Yes the code is incredibly fragile, but i've no idea why you decided to change this \
given this is not a user visible string.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D16749
To: snoordhuis, #vdg, #localization, yurchor, ngraham
Cc: aacid, ngraham, yurchor, graesslin, kwin, mkulinski, ragreen, jackyalcine, Pitel, \
iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, \
sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">aacid added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D16749">View Revision</a></tr></table><br \
/><div><strong>INLINE COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D16749#inline-91248">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">keyboard_layout.cpp:196</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; "> <span style="color: #74777d">// \
layout name is translated in the action name in keyboard kcm!</span> </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, .7);"> \
<span style="color: #aa4000">const</span> <span class="n">QString</span> <span \
class="n">action</span> <span style="color: #aa2211">=</span> <span \
class="n">QStringLiteral</span><span class="p">(</span><span style="color: \
#766510">"Switch <span class="bright">k</span>eyboard <span \
class="bright">l</span>ayout to %1"</span><span class="p">).</span><span \
class="n">arg</span><span class="p">(</span><span \
class="n">translatedLayout</span><span class="p">(</span><span \
class="n">it</span><span class="p">.</span><span class="n">value</span><span \
class="p">()));</span> </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(151, 234, 151, .6);"> <span style="color: #aa4000">const</span> <span \
class="n">QString</span> <span class="n">action</span> <span style="color: \
#aa2211">=</span> <span class="n">QStringLiteral</span><span class="p">(</span><span \
style="color: #766510">"Switch <span class="bright">K</span>eyboard <span \
class="bright">L</span>ayout to %1"</span><span class="p">).</span><span \
class="n">arg</span><span class="p">(</span><span \
class="n">translatedLayout</span><span class="p">(</span><span \
class="n">it</span><span class="p">.</span><span class="n">value</span><span \
class="p">()));</span> </div><div style="padding: 0 8px; margin: 0 4px; "> \
<span style="color: #aa4000">const</span> <span style="color: #aa4000">auto</span> \
<span class="n">shortcuts</span> <span style="color: #aa2211">=</span> <span \
class="n">KGlobalAccel</span><span style="color: #aa2211">::</span><span \
class="n">self</span><span class="p">()</span><span style="color: \
#aa2211">-></span><span class="n">globalShortcut</span><span \
class="p">(</span><span class="n">componentName</span><span class="p">,</span> <span \
class="n">action</span><span class="p">);</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">Have \
you tested this? Because you're breaking things with this change.</p>
<p style="padding: 0; margin: 8px;">Yes the code is incredibly fragile, but i've \
no idea why you decided to change this given this is not a user visible \
string.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D16749">https://phabricator.kde.org/D16749</a></div></div><br \
/><div><strong>To: </strong>snoordhuis, VDG, Localization, yurchor, ngraham<br \
/><strong>Cc: </strong>aacid, ngraham, yurchor, graesslin, kwin, mkulinski, ragreen, \
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic