[prev in list] [next in list] [prev in thread] [next in thread]
List: kwin
Subject: D16749: Various grammar and capitalization fixes for UI consistency
From: Nathaniel Graham <noreply () phabricator ! kde ! org>
Date: 2018-11-08 14:00:46
Message-ID: c08152cf1b9ec56ce6fb72b927b22731 () localhost ! localdomain
[Download RAW message or body]
[Attachment #2 (text/plain)]
ngraham requested changes to this revision.
ngraham added a comment.
This revision now requires changes to proceed.
IMHO it generally makes sense to improve string--as long as they are genuine \
improvements!
I'm okay with some of these changes but amincreasingly unsure that changing the \
"Comment" fields on the desktop files is a good idea. That field determines the \
largest string on the page that //looks// like its effective title. However \
semantically it's not the title; it's really more of a caption. But its size and \
position makes it look like a title and the result is a little odd:
F6398172: Inconsistent titles.png <https://phabricator.kde.org/F6398172>
I think it would be worth putting some thought into coming up with an improved \
visual design that gives less prominence to the Comment so that it doesn't look like \
a title and feel inconsistent with the other displayed title-like strings in the UI. \
Once we do that, then changing the capitalization may not be necessary since the \
comment would return to its proper place as a simple caption which probably doesn't \
need to be in Title Case.
INLINE COMMENTS
> kwindecoration.desktop:83
> Comment[el]=Διαμόρφωση της εμφάνισης και αίσθησης \
> του τίτλου των παραθύρων
> -Comment[en_GB]=Look and Feel of Window Titles
> +Comment[en_GB]=Window Style and Decorations
> Comment[es]=Aspecto visual de los títulos de las ventanas
Revert this change; it happens automatically.
> kwindecoration.desktop:116
> Comment[uk]=Вигляд і поведінка смужок заголовків \
> вікон
> -Comment[x-test]=xxLook and Feel of Window Titlesxx
> +Comment[x-test]=xxWindow Style and Decorationsxx
> Comment[zh_CN]=窗口 题的观感
Revert this change; it happens automatically.
> kwintouchscreen.desktop:56
> Comment[de]=Wischgesten für Touchscreens
> -Comment[en_GB]=Touch screen swipe gestures
> +Comment[en_GB]=Touch Screen Swipe Gestures
> Comment[es]=Gestos de deslizamiento en pantalla táctil
Revert this change; it happens automatically.
> kwintouchscreen.desktop:83
> Comment[uk]=Жести на сенсорній панелі
> -Comment[x-test]=xxTouch screen swipe gesturesxx
> +Comment[x-test]=xxTouch Screen Swipe Gesturesxx
> Comment[zh_CN]=触摸屏滑动手势
Revert this change; it happens automatically.
> kwinscripts.desktop:121
> Comment[el]=Διαχείριση σεναρίων KWin
> -Comment[en_GB]=Manage KWin scripts
> +Comment[en_GB]=Manage KWin Scripts
> Comment[es]=Gestionar guiones de KWin
Revert this change; it happens automatically.
> kwinscripts.desktop:159
> Comment[vi]=Quản lý tập lệnh KWin
> -Comment[x-test]=xxManage KWin scriptsxx
> +Comment[x-test]=xxManage KWin Scriptsxx
> Comment[zh_CN]=管理 KWin 脚本
Revert this change; it happens automatically.
> kwintabbox.desktop:81
> Comment[el]= εριήγηση στα παράθυρα
> -Comment[en_GB]=Navigation Through Windows
> +Comment[en_GB]=Navigation through Windows
> Comment[es]=Navegación a través de las ventanas
Revert this change; it happens automatically.
> kwintabbox.desktop:113
> Comment[vi]=Điều hướng qua các cửa sổ
> -Comment[x-test]=xxNavigation Through Windowsxx
> +Comment[x-test]=xxNavigation through Windowsxx
> Comment[zh_CN]=遍历窗口
Revert this change; it happens automatically.
REPOSITORY
R108 KWin
REVISION DETAIL
https://phabricator.kde.org/D16749
To: snoordhuis, #vdg, #localization, yurchor, ngraham
Cc: ngraham, yurchor, graesslin, kwin, mkulinski, ragreen, jackyalcine, Pitel, \
iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, jensreuterberg, abetts, \
sebas, apol, mart
[Attachment #3 (text/html)]
<table><tr><td style="">ngraham requested changes to this revision.<br />ngraham \
added a comment.<br />This revision now requires changes to proceed. </td><a \
style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: right; \
color: #464C5C; font-weight: bold; border-radius: 3px; background-color: #F7F7F9; \
background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: inline-block; \
border: 1px solid rgba(71,87,120,.2);" href="https://phabricator.kde.org/D16749">View \
Revision</a></tr></table><br /><div><div><p>IMHO it generally makes sense to improve \
string--as long as they are genuine improvements!</p>
<p>I'm okay with some of these changes but amincreasingly unsure that changing \
the "Comment" fields on the desktop files is a good idea. That field \
determines the largest string on the page that <em>looks</em> like its effective \
title. However semantically it's not the title; it's really more of a \
caption. But its size and position makes it look like a title and the result is a \
little odd:</p>
<p><a href="https://phabricator.kde.org/F6398172" style="background-color: #e7e7e7;
border-color: #e7e7e7;
border-radius: 3px;
padding: 0 4px;
font-weight: bold;
color: black;text-decoration: none;">F6398172: Inconsistent \
titles.png</a></p>
<p>I think it would be worth putting some thought into coming up with an improved \
visual design that gives less prominence to the Comment so that it doesn't look \
like a title and feel inconsistent with the other displayed title-like strings in the \
UI. Once we do that, then changing the capitalization may not be necessary since the \
comment would return to its proper place as a simple caption which probably \
doesn't need to be in Title Case.</p></div></div><br /><div><strong>INLINE \
COMMENTS</strong><div><div style="margin: 6px 0 12px 0;"><div style="border: 1px \
solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; background: #F7F7F7; \
border-color: #e3e4e8; border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div \
style="color: #74777d; background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a \
style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D16749#inline-91228">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">kwindecoration.desktop:83</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; \
">Comment[el]=Διαμόρφωση της εμφάνισης και αίσθησης \
του τίτλου των παραθύρων </div><div style="padding: 0 8px; \
margin: 0 4px; background: rgba(251, 175, 175, .7);">Comment[en_GB]=<span \
class="bright">Look and Feel of </span>Window <span class="bright">Title</span>s \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">Comment[en_GB]=Window <span class="bright">Style and Decoration</span>s \
</div><div style="padding: 0 8px; margin: 0 4px; ">Comment[es]=Aspecto visual de los \
títulos de las ventanas </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Revert this change; it happens automatically.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D16749#inline-91229">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">kwindecoration.desktop:116</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">Comment[uk]=Вигляд і \
поведінка смужок заголовків вікон </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);">Comment[x-test]=xx<span class="bright">Look and Feel of </span>Window <span \
class="bright">Title</span>sxx </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">Comment[x-test]=xxWindow <span \
class="bright">Style and Decoration</span>sxx </div><div style="padding: 0 8px; \
margin: 0 4px; ">Comment[zh_CN]=窗口 题的观感 </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Revert this change; it happens automatically.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D16749#inline-91230">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">kwintouchscreen.desktop:56</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">Comment[de]=Wischgesten für \
Touchscreens </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, \
175, 175, .7);">Comment[en_GB]=Touch <span class="bright">s</span>creen <span \
class="bright">s</span>wipe <span class="bright">g</span>estures </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">Comment[en_GB]=Touch <span class="bright">S</span>creen <span \
class="bright">S</span>wipe <span class="bright">G</span>estures </div><div \
style="padding: 0 8px; margin: 0 4px; ">Comment[es]=Gestos de deslizamiento en \
pantalla táctil </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Revert this change; it happens automatically.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D16749#inline-91231">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">kwintouchscreen.desktop:83</span></div> \
<div style="font: 11px/15px "Menlo", "Consolas", \
"Monaco", monospace; white-space: pre-wrap; clear: both; padding: 4px 0; \
margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">Comment[uk]=Жести на \
сенсорній панелі </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(251, 175, 175, .7);">Comment[x-test]=xxTouch <span \
class="bright">s</span>creen <span class="bright">s</span>wipe <span \
class="bright">g</span>esturesxx </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">Comment[x-test]=xxTouch <span \
class="bright">S</span>creen <span class="bright">S</span>wipe <span \
class="bright">G</span>esturesxx </div><div style="padding: 0 8px; margin: 0 4px; \
">Comment[zh_CN]=触摸屏滑动手势 </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Revert this change; it happens automatically.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D16749#inline-91232">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">kwinscripts.desktop:121</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; ">Comment[el]=Διαχείριση \
σεναρίων KWin </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);">Comment[en_GB]=Manage KWin <span \
class="bright">s</span>cripts </div><div style="padding: 0 8px; margin: 0 4px; \
background: rgba(151, 234, 151, .6);">Comment[en_GB]=Manage KWin <span \
class="bright">S</span>cripts </div><div style="padding: 0 8px; margin: 0 4px; \
">Comment[es]=Gestionar guiones de KWin </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Revert this change; it happens automatically.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D16749#inline-91233">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">kwinscripts.desktop:159</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; ">Comment[vi]=Quản lý tập lệnh KWin \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);">Comment[x-test]=xxManage KWin <span class="bright">s</span>criptsxx </div><div \
style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">Comment[x-test]=xxManage KWin <span class="bright">S</span>criptsxx </div><div \
style="padding: 0 8px; margin: 0 4px; ">Comment[zh_CN]=管理 KWin 脚本 \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Revert this change; it happens automatically.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D16749#inline-91234">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">kwintabbox.desktop:81</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; ">Comment[el]= εριήγηση στα \
παράθυρα </div><div style="padding: 0 8px; margin: 0 4px; background: \
rgba(251, 175, 175, .7);">Comment[en_GB]=Navigation <span \
class="bright">T</span>hrough Windows </div><div style="padding: 0 8px; margin: 0 \
4px; background: rgba(151, 234, 151, .6);">Comment[en_GB]=Navigation <span \
class="bright">t</span>hrough Windows </div><div style="padding: 0 8px; margin: 0 \
4px; ">Comment[es]=Navegación a través de las ventanas </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: \
8px;">Revert this change; it happens automatically.</p></div></div><br /><div \
style="border: 1px solid #C7CCD9; border-radius: 3px;"><div style="padding: 0; \
background: #F7F7F7; border-color: #e3e4e8; border-style: solid; border-width: 0 0 \
1px 0; margin: 0;"><div style="color: #74777d; background: #eff2f4; padding: 6px 8px; \
overflow: hidden;"><a style="float: right; text-decoration: none;" \
href="https://phabricator.kde.org/D16749#inline-91235">View Inline</a><span \
style="color: #4b4d51; font-weight: bold;">kwintabbox.desktop:113</span></div> <div \
style="font: 11px/15px "Menlo", "Consolas", "Monaco", \
monospace; white-space: pre-wrap; clear: both; padding: 4px 0; margin: 0;"><div \
style="padding: 0 8px; margin: 0 4px; ">Comment[vi]=Điều hướng qua các cửa \
sổ </div><div style="padding: 0 8px; margin: 0 4px; background: rgba(251, 175, 175, \
.7);">Comment[x-test]=xxNavigation <span class="bright">T</span>hrough Windowsxx \
</div><div style="padding: 0 8px; margin: 0 4px; background: rgba(151, 234, 151, \
.6);">Comment[x-test]=xxNavigation <span class="bright">t</span>hrough Windowsxx \
</div><div style="padding: 0 8px; margin: 0 4px; ">Comment[zh_CN]=遍历窗口 \
</div></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; \
margin: 8px;">Revert this change; it happens \
automatically.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R108 KWin</div></div></div><br \
/><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D16749">https://phabricator.kde.org/D16749</a></div></div><br \
/><div><strong>To: </strong>snoordhuis, VDG, Localization, yurchor, ngraham<br \
/><strong>Cc: </strong>ngraham, yurchor, graesslin, kwin, mkulinski, ragreen, \
jackyalcine, Pitel, iodelay, bwowk, ZrenBot, lesliezhai, ali-mohamed, hardening, \
jensreuterberg, abetts, sebas, apol, mart<br /></div>
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic