[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-i18n-doc
Subject: Re: Review Request 120618: Add Messages.sh to kaccounts-providers
From: "Luigi Toscano" <luigi.toscano () tiscali ! it>
Date: 2015-12-24 0:13:44
Message-ID: 20151224001344.29845.80134 () mimi ! kde ! org
[Download RAW message or body]
--===============3708521718575721788==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
> On Ott. 22, 2014, 12:32 a.m., Albert Astals Cid wrote:
> > I didn't comment because i have been traveling and sprinting and wanted to \
> > suggest something better than a comment, but anywhere here it is: i think that \
> > using -a is a really bad idea and you should be using -k to specify the keyword, \
> > otherwise if you end up having a regular string in some other header it'll get \
> > extracted too.
>
> Martin Klapetek wrote:
> This repo contains only those xml files (plus icons and other data), so the only \
> header files in there will be those generated by the intltool-extract, so should be \
> safe. But if really needed, I can change.
> Albert Astals Cid wrote:
> Ok, if you promise you're never going to add any other header file, this is ok.
>
> Martin Klapetek wrote:
> I can promise.
>
> However, looking at l10n.kde.org - I don't see the .po file generated by this, how \
> come? Proper branch is set at projects.k.o.
> Albert Astals Cid wrote:
> should be fixed in tonights run.
For the record: the repository contains real code now too and -a extracts everything.
- Luigi
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/120618/#review68859
-----------------------------------------------------------
On Ott. 21, 2014, 11:16 p.m., Martin Klapetek wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/120618/
> -----------------------------------------------------------
>
> (Updated Ott. 21, 2014, 11:16 p.m.)
>
>
> Review request for Localization and Translation (l10n).
>
>
> Repository: kaccounts-providers
>
>
> Description
> -------
>
> Based on the discussion at kde-i18n-doc@, here's the Messages.sh for \
> kaccounts-providers.
> Uses intltool-extract to extract the messages from xml into C headers, then uses \
> xgettext to extract those into pot.
> I added -c to xgettext so it also extracts comments for translators and -a as \
> otherwise it wouldn't extract anything from the output of intltool-extract. I \
> haven't found these in XGETTEXT_FLAGS so added them manually, let me know if they \
> should be gone.
>
> Diffs
> -----
>
> Messages.sh PRE-CREATION
>
> Diff: https://git.reviewboard.kde.org/r/120618/diff/
>
>
> Testing
> -------
>
> Run Messages.sh and checked the .pot file. It contained all the strings and \
> comments.
>
> Thanks,
>
> Martin Klapetek
>
>
--===============3708521718575721788==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/120618/">https://git.reviewboard.kde.org/r/120618/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On ottobre 22nd, 2014, 12:32 a.m. CEST, <b>Albert \
Astals Cid</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px \
solid #d0d0d0; padding-left: 10px;"> <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I didn't comment because i have been traveling and \
sprinting and wanted to suggest something better than a comment, but anywhere here it \
is: i think that using -a is a really bad idea and you should be using -k to specify \
the keyword, otherwise if you end up having a regular string in some other header \
it'll get extracted too.</p></pre> </blockquote>
<p>On ottobre 22nd, 2014, 9:50 a.m. CEST, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">This \
repo contains only those xml files (plus icons and other data), so the only header \
files in there will be those generated by the intltool-extract, so should be safe. \
But if really needed, I can change.</p></pre> </blockquote>
<p>On ottobre 27th, 2014, 9:38 p.m. CET, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ok, \
if you promise you're never going to add any other header file, this is ok.</p></pre> \
</blockquote>
<p>On ottobre 28th, 2014, 8:37 a.m. CET, <b>Martin Klapetek</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">I can \
promise.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">However, looking at l10n.kde.org - I don't see the .po \
file generated by this, how come? Proper branch is set at projects.k.o.</p></pre> \
</blockquote>
<p>On ottobre 29th, 2014, 12:28 a.m. CET, <b>Albert Astals Cid</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">should be fixed in tonights run.</p></pre> </blockquote>
</blockquote>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">For \
the record: the repository contains real code now too and -a extracts \
everything.</p></pre> <br />
<p>- Luigi</p>
<br />
<p>On ottobre 21st, 2014, 11:16 p.m. CEST, Martin Klapetek wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for Localization and Translation (l10n).</div>
<div>By Martin Klapetek.</div>
<p style="color: grey;"><i>Updated Ott. 21, 2014, 11:16 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kaccounts-providers
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Based on the discussion at kde-i18n-doc@, here's the \
Messages.sh for kaccounts-providers.</p> <p style="padding: 0;text-rendering: \
inherit;margin: 0;line-height: inherit;white-space: inherit;">Uses intltool-extract \
to extract the messages from xml into C headers, then uses xgettext to extract those \
into pot.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I added -c to xgettext so it also extracts comments \
for translators and -a as otherwise it wouldn't extract anything from the output of \
intltool-extract. I haven't found these in XGETTEXT_FLAGS so added them manually, let \
me know if they should be gone.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">Run Messages.sh and checked the .pot file. It \
contained all the strings and comments.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>Messages.sh <span style="color: grey">(PRE-CREATION)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/120618/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============3708521718575721788==--
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic