--===============3708521718575721788== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit > On Ott. 22, 2014, 12:32 a.m., Albert Astals Cid wrote: > > I didn't comment because i have been traveling and sprinting and wanted to suggest something better than a comment, but anywhere here it is: i think that using -a is a really bad idea and you should be using -k to specify the keyword, otherwise if you end up having a regular string in some other header it'll get extracted too. > > Martin Klapetek wrote: > This repo contains only those xml files (plus icons and other data), so the only header files in there will be those generated by the intltool-extract, so should be safe. But if really needed, I can change. > > Albert Astals Cid wrote: > Ok, if you promise you're never going to add any other header file, this is ok. > > Martin Klapetek wrote: > I can promise. > > However, looking at l10n.kde.org - I don't see the .po file generated by this, how come? Proper branch is set at projects.k.o. > > Albert Astals Cid wrote: > should be fixed in tonights run. For the record: the repository contains real code now too and -a extracts everything. - Luigi ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120618/#review68859 ----------------------------------------------------------- On Ott. 21, 2014, 11:16 p.m., Martin Klapetek wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/120618/ > ----------------------------------------------------------- > > (Updated Ott. 21, 2014, 11:16 p.m.) > > > Review request for Localization and Translation (l10n). > > > Repository: kaccounts-providers > > > Description > ------- > > Based on the discussion at kde-i18n-doc@, here's the Messages.sh for kaccounts-providers. > > Uses intltool-extract to extract the messages from xml into C headers, then uses xgettext to extract those into pot. > > I added -c to xgettext so it also extracts comments for translators and -a as otherwise it wouldn't extract anything from the output of intltool-extract. I haven't found these in XGETTEXT_FLAGS so added them manually, let me know if they should be gone. > > > Diffs > ----- > > Messages.sh PRE-CREATION > > Diff: https://git.reviewboard.kde.org/r/120618/diff/ > > > Testing > ------- > > Run Messages.sh and checked the .pot file. It contained all the strings and comments. > > > Thanks, > > Martin Klapetek > > --===============3708521718575721788== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/120618/

On ottobre 22nd, 2014, 12:32 a.m. CEST, Albert Astals Cid wrote:

I didn't comment because i have been traveling and sprinting and wanted to suggest something better than a comment, but anywhere here it is: i think that using -a is a really bad idea and you should be using -k to specify the keyword, otherwise if you end up having a regular string in some other header it'll get extracted too.

On ottobre 22nd, 2014, 9:50 a.m. CEST, Martin Klapetek wrote:

This repo contains only those xml files (plus icons and other data), so the only header files in there will be those generated by the intltool-extract, so should be safe. But if really needed, I can change.

On ottobre 27th, 2014, 9:38 p.m. CET, Albert Astals Cid wrote:

Ok, if you promise you're never going to add any other header file, this is ok.

On ottobre 28th, 2014, 8:37 a.m. CET, Martin Klapetek wrote:

I can promise.

However, looking at l10n.kde.org - I don't see the .po file generated by this, how come? Proper branch is set at projects.k.o.

On ottobre 29th, 2014, 12:28 a.m. CET, Albert Astals Cid wrote:

should be fixed in tonights run.

For the record: the repository contains real code now too and -a extracts everything.

- Luigi

On ottobre 21st, 2014, 11:16 p.m. CEST, Martin Klapetek wrote:

Review request for Localization and Translation (l10n).

By Martin Klapetek.

Updated Ott. 21, 2014, 11:16 p.m.

Repository: kaccounts-providers

Description

Based on the discussion at kde-i18n-doc@, here's the Messages.sh for kaccounts-providers.
Uses intltool-extract to extract the messages from xml into C headers, then uses xgettext to extract those into pot.
I added -c to xgettext so it also extracts comments for translators and -a as otherwise it wouldn't extract anything from the output of intltool-extract. I haven't found these in XGETTEXT_FLAGS so added them manually, let me know if they should be gone.

Testing

Run Messages.sh and checked the .pot file. It contained all the strings and comments.

Diffs

Messages.sh (PRE-CREATION)

--===============3708521718575721788==--