[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-i18n-doc
Subject:    [PATCH] l10n-kde4/scripts/autogen.sh
From:       Alex Merry <kde () randomguy3 ! me ! uk>
Date:       2010-03-05 11:50:13
Message-ID: 201003051150.13552.kde () randomguy3 ! me ! uk
[Download RAW message or body]

Is it OK to apply the following patch to autogen.sh?

revpath comes as part of the imake package.  There is no particular reason 
this should be installed on a system, and it's not obvious what package the 
user should install.  On top of that, the error message output by the script 
if it's missing isn't that helpful.

So: this is a small change to warn the user if it is missing.  I was as 
conservative as possible - not exiting with an error if "which" can't find 
revpath - because I don't fancy having lots of angry translators on my back 
because I broke something :-)

Alex

PS: I'm not on the kde-i18n list, so please CC me.



Index: l10n-kde4/scripts/autogen.sh
===================================================================
--- l10n-kde4/scripts/autogen.sh        (revision 1099047)
+++ l10n-kde4/scripts/autogen.sh        (working copy)
@@ -1,6 +1,11 @@
 CDPATH=
 # requires find, sed, revpath, egrep, grep, fgrep, cat, rm, basename
 
+if ! which revpath >/dev/null 2>/dev/null; then
+    echo "!!! Cannot find revpath: this script may fail" >&2
+    echo "!!! Try installing the imake package" >&2
+fi
+
 add_cmake_files_manpage() {
   local dir_local=$1;
   for manfile in `find $dir_local/ -name man-*.docbook`; do
[prev in list] [next in list] [prev in thread] [next in thread]