[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-hardware-devel
Subject:    Re: [Kde-hardware-devel] Making Solid give a visible name for
From:       Kevin Ottens <ervin () kde ! org>
Date:       2009-04-17 8:52:42
Message-ID: 200904171052.43123.ervin () kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/signed)]


On Friday 10 April 2009 17:00:28 Albert Astals Cid wrote:
> i'm attaching a patch that adds the visibleName function for Solid
> devices, that is useful for places like the places viewer in dolphin or the
> device notifier in plasma. Currently when i connect my phone i get "Volume
> (fat32)" which sucks for two reasons:
>  * It's not much detailed

Which is the real issue.

>  * Can't be translated

Which is in my opinion a side effect of the real issue.

> With the current patch, the "Can't be translated" part is fixed and now i
> get "7,4 GiB External Media" that is not a great improvement but at least
> can be translated.

Well, looks like you're treating a symptom and not the cause in this case, 
isn't it? I'm not sold on the approach... We should probably try to instead 
report a better string in the first place, not something equally bad but 
translatable. I suspect the right fix would be in HAL, but that's maybe 
something we could workaround.

In any case we probably want to make sure vendor()+product() gives us 
something sensible, I'm not fan of having another method to call for that.

Could you provide your "solid-hardware list details" and solid-hardware list 
nonportableinfo" outputs with the phone connected? Bonus point if you give us 
the udi of the phone itself (makes it easier to look for the right info).

Regards.
-- 
Kévin 'ervin' Ottens, http://ervin.ipsquad.net
"Ni le maître sans disciple, Ni le disciple sans maître,
Ne font reculer l'ignorance."

["signature.asc" (application/pgp-signature)]

_______________________________________________
Kde-hardware-devel mailing list
Kde-hardware-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-hardware-devel


[prev in list] [next in list] [prev in thread] [next in thread]