From kde-hardware-devel Fri Apr 17 08:52:42 2009 From: Kevin Ottens Date: Fri, 17 Apr 2009 08:52:42 +0000 To: kde-hardware-devel Subject: Re: [Kde-hardware-devel] Making Solid give a visible name for Message-Id: <200904171052.43123.ervin () kde ! org> X-MARC-Message: https://marc.info/?l=kde-hardware-devel&m=123995978208622 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============1078740692==" --===============1078740692== Content-Type: multipart/signed; boundary="nextPart3449361.JmIqZ8Yt7Y"; protocol="application/pgp-signature"; micalg=pgp-sha1 Content-Transfer-Encoding: 7bit --nextPart3449361.JmIqZ8Yt7Y Content-Type: text/plain; charset="iso-8859-1" Content-Transfer-Encoding: quoted-printable Content-Disposition: inline On Friday 10 April 2009 17:00:28 Albert Astals Cid wrote: > i'm attaching a patch that adds the visibleName function for Solid > devices, that is useful for places like the places viewer in dolphin or t= he > device notifier in plasma. Currently when i connect my phone i get "Volume > (fat32)" which sucks for two reasons: > * It's not much detailed Which is the real issue. > * Can't be translated Which is in my opinion a side effect of the real issue. > With the current patch, the "Can't be translated" part is fixed and now i > get "7,4 GiB External Media" that is not a great improvement but at least > can be translated. Well, looks like you're treating a symptom and not the cause in this case,= =20 isn't it? I'm not sold on the approach... We should probably try to instead= =20 report a better string in the first place, not something equally bad but=20 translatable. I suspect the right fix would be in HAL, but that's maybe=20 something we could workaround. In any case we probably want to make sure vendor()+product() gives us=20 something sensible, I'm not fan of having another method to call for that. Could you provide your "solid-hardware list details" and solid-hardware lis= t=20 nonportableinfo" outputs with the phone connected? Bonus point if you give = us=20 the udi of the phone itself (makes it easier to look for the right info). Regards. =2D-=20 K=E9vin 'ervin' Ottens, http://ervin.ipsquad.net "Ni le ma=EEtre sans disciple, Ni le disciple sans ma=EEtre, Ne font reculer l'ignorance." --nextPart3449361.JmIqZ8Yt7Y Content-Type: application/pgp-signature; name=signature.asc Content-Description: This is a digitally signed message part. -----BEGIN PGP SIGNATURE----- Version: GnuPG v2.0.9 (GNU/Linux) iEYEABECAAYFAknoQ1sACgkQB0u7y43syeLP+ACeNKYxPqyxhBRw/WIUCmR4l163 d3UAn2NNsv99bY2vWqLW83cy5t4oFsu9 =xlcc -----END PGP SIGNATURE----- --nextPart3449361.JmIqZ8Yt7Y-- --===============1078740692== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-hardware-devel mailing list Kde-hardware-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-hardware-devel --===============1078740692==--