[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 121589: Rename binary to ksnakeduel
From: "Albert Astals Cid" <aacid () kde ! org>
Date: 2015-01-02 21:36:18
Message-ID: 20150102213618.30560.36835 () probe ! kde ! org
[Download RAW message or body]
--===============4505299275778464091==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121589/#review72985
-----------------------------------------------------------
So we will have two binaries, ksnakeduel and kdesnake? Seems weird, maybe what you \
should do is rename the kdesnake to ksnakeduel?
- Albert Astals Cid
On des. 18, 2014, 3:56 p.m., Jonathan Riddell wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121589/
> -----------------------------------------------------------
>
> (Updated des. 18, 2014, 3:56 p.m.)
>
>
> Review request for KDE Games.
>
>
> Repository: ksnakeduel
>
>
> Description
> -------
>
> For some reason ksnakeduel has three names. This gets rid of one of them, ktron and \
> changes it to ksnakeduel. This was mostly done already but this changes the binary \
> name too which was causing confusion to us little packagers.
> I also think the kdesnake script and .desktop file should go away, you can set it \
> in the UI.
>
> Diffs
> -----
>
> CMakeLists.txt 49616d7
> kdesnake.cmake 0a4e46d
>
> Diff: https://git.reviewboard.kde.org/r/121589/diff/
>
>
> Testing
> -------
>
> compile, install and run
>
>
> Thanks,
>
> Jonathan Riddell
>
>
--===============4505299275778464091==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/121589/">https://git.reviewboard.kde.org/r/121589/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">So we \
will have two binaries, ksnakeduel and kdesnake? Seems weird, maybe what you should \
do is rename the kdesnake to ksnakeduel?</p></pre> <br />
<p>- Albert Astals Cid</p>
<br />
<p>On desembre 18th, 2014, 3:56 p.m. UTC, Jonathan Riddell wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Games.</div>
<div>By Jonathan Riddell.</div>
<p style="color: grey;"><i>Updated des. 18, 2014, 3:56 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
ksnakeduel
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">For some reason ksnakeduel has three names. This gets \
rid of one of them, ktron and changes it to ksnakeduel. This was mostly done already \
but this changes the binary name too which was causing confusion to us little \
packagers.</p> <p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I also think the kdesnake script and .desktop file \
should go away, you can set it in the UI.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">compile, install and run</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>CMakeLists.txt <span style="color: grey">(49616d7)</span></li>
<li>kdesnake.cmake <span style="color: grey">(0a4e46d)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/121589/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============4505299275778464091==--
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic