From kde-games-devel Fri Jan 02 21:36:18 2015 From: "Albert Astals Cid" Date: Fri, 02 Jan 2015 21:36:18 +0000 To: kde-games-devel Subject: Re: [Kde-games-devel] Review Request 121589: Rename binary to ksnakeduel Message-Id: <20150102213618.30560.36835 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-games-devel&m=142023459425411 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============2513238976419386971==" --===============2513238976419386971== Content-Type: multipart/alternative; boundary="===============4505299275778464091==" --===============4505299275778464091== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121589/#review72985 ----------------------------------------------------------- So we will have two binaries, ksnakeduel and kdesnake? Seems weird, maybe what you should do is rename the kdesnake to ksnakeduel? - Albert Astals Cid On des. 18, 2014, 3:56 p.m., Jonathan Riddell wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121589/ > ----------------------------------------------------------- > > (Updated des. 18, 2014, 3:56 p.m.) > > > Review request for KDE Games. > > > Repository: ksnakeduel > > > Description > ------- > > For some reason ksnakeduel has three names. This gets rid of one of them, ktron and changes it to ksnakeduel. This was mostly done already but this changes the binary name too which was causing confusion to us little packagers. > > I also think the kdesnake script and .desktop file should go away, you can set it in the UI. > > > Diffs > ----- > > CMakeLists.txt 49616d7 > kdesnake.cmake 0a4e46d > > Diff: https://git.reviewboard.kde.org/r/121589/diff/ > > > Testing > ------- > > compile, install and run > > > Thanks, > > Jonathan Riddell > > --===============4505299275778464091== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121589/

So we will have two binaries, ksnakeduel and kdesnake? Seems weird, maybe what you should do is rename the kdesnake to ksnakeduel?

- Albert Astals Cid

On desembre 18th, 2014, 3:56 p.m. UTC, Jonathan Riddell wrote:

Review request for KDE Games.

By Jonathan Riddell.

Updated des. 18, 2014, 3:56 p.m.

Repository: ksnakeduel

Description

For some reason ksnakeduel has three names. This gets rid of one of them, ktron and changes it to ksnakeduel. This was mostly done already but this changes the binary name too which was causing confusion to us little packagers.

I also think the kdesnake script and .desktop file should go away, you can set it in the UI.

Testing

compile, install and run

Diffs

CMakeLists.txt (49616d7)
kdesnake.cmake (0a4e46d)

View Diff

--===============4505299275778464091==-- --===============2513238976419386971== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ kde-games-devel mailing list kde-games-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-games-devel --===============2513238976419386971==--