'Re: [Kde-games-devel] Review Request 121653: Break out parts of updateSpriteMap to reduce code dupli'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Review Request 121653: Break out parts of updateSpriteMap to reduce code dupli
From:       "Albert Astals Cid" <aacid () kde ! org>
Date:       2015-01-02 21:54:40
Message-ID: 20150102215440.30560.25420 () probe ! kde ! org
[Download RAW message or body]

--===============1654555981185686538==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121653/#review72986
-----------------------------------------------------------

Ship it!

Looks good, i'll commit it

- Albert Astals Cid

On des. 23, 2014, 8:28 p.m., Jan-Peter Nilsson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121653/
> -----------------------------------------------------------
> 
> (Updated des. 23, 2014, 8:28 p.m.)
> 
> 
> Review request for KDE Games.
> 
> 
> Repository: kmahjongg
> 
> 
> Description
> -------
> 
> This patch breaks out parts of updateSpriteMap to private methods in order to \
> reduce code duplication between the different viewing angles. 
> 
> Diffs
> -----
> 
> boardwidget.h f1e0483 
> boardwidget.cpp 04ba8c5 
> 
> Diff: https://git.reviewboard.kde.org/r/121653/diff/
> 
> 
> Testing
> -------
> 
> I have verified that the center tile of the default layout remain at the same \
> position as with the original code for all four angles. 
> 
> Thanks,
> 
> Jan-Peter Nilsson
> 
> 

--===============1654555981185686538==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121653/">https://git.reviewboard.kde.org/r/121653/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Looks \
good, i'll commit it</p></pre>  <br />

<p>- Albert Astals Cid</p>

<br />
<p>On desembre 23rd, 2014, 8:28 p.m. UTC, Jan-Peter Nilsson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Games.</div>
<div>By Jan-Peter Nilsson.</div>

<p style="color: grey;"><i>Updated des. 23, 2014, 8:28 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kmahjongg
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This patch breaks out parts of updateSpriteMap to \
private methods in order to reduce code duplication between the different viewing \
angles.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I have verified that the center tile of the default \
layout remain at the same position as with the original code for all four \
angles.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>boardwidget.h <span style="color: grey">(f1e0483)</span></li>

 <li>boardwidget.cpp <span style="color: grey">(04ba8c5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121653/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1654555981185686538==--

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread] 