'Re: [Kde-games-devel] Review Request 114639: [knavalbattle] avoid semi-transparents first shots'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-games-devel
Subject:    Re: [Kde-games-devel] Review Request 114639: [knavalbattle] avoid semi-transparents first shots
From:       "Jaime Torres Amate" <jtamate () gmail ! com>
Date:       2013-12-29 9:47:46
Message-ID: 20131229094746.21905.92895 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/114639/
-----------------------------------------------------------

(Updated Dec. 29, 2013, 9:47 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Games and Roney Gomes.

Bugs: 320883
    http://bugs.kde.org/show_bug.cgi?id=320883

Repository: knavalbattle

Description
-------

Before, after a match against the AI, and a Restart, the first shot was always semi-transparent \
(or gray in the sea). Initialize 3 variables, and the shots are always the same (white in the \
sea).

Diffs
-----

  src/animation.cpp 951b5a6 
  src/button.cpp 3ff23a5 

Diff: https://git.reviewboard.kde.org/r/114639/diff/

Testing
-------

It has been tested more than a hundred times (while testing the several ships and shunk ships \
patches)

Thanks,

Jaime Torres Amate

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 solid;">
    <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/114639/">https://git.reviewboard.kde.org/r/114639/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="8" style="border: 1px gray solid;">
 <tr>
  <td>
   <h1 style="margin-right: 0.2em; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black solid;">  <tr>
  <td>

<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>

<p style="color: grey;"><i>Updated Dec. 29, 2013, 9:47 a.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>

 <a href="http://bugs.kde.org/show_bug.cgi?id=320883">320883</a>

</div>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
knavalbattle
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px \
solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Before, after a match \
against the AI, and a Restart, the first shot was always semi-transparent (or gray in the sea). \
Initialize 3 variables, and the shots are always the same (white in the sea).</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: 1px solid \
#b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">It has been tested \
more than a hundred times (while testing the several ships and shunk ships patches)</pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/animation.cpp <span style="color: grey">(951b5a6)</span></li>

 <li>src/button.cpp <span style="color: grey">(3ff23a5)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/114639/diff/" style="margin-left: 3em;">View \
Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel

[prev in list] [next in list] [prev in thread] [next in thread] 