[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request 114620: [knavalbattle] Show not shunk ships when the game finis
From: Jaime <jtamate () gmail ! com>
Date: 2013-12-29 9:47:25
Message-ID: CAJd4GE+MT+aX5z6pFPiNiP_ckbNrFY=pS_oOxWGJw8rQwy0jUw () mail ! gmail ! com
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
I'm sorry, the review closed is the other one, I've copied/pasted the wrong
number. This one is still open.
2013/12/29 Commit Hook <null@kde.org>
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/114620/
>
> This review has been submitted with commit df86bb2e2480f5b737b113f51a56638638e6201d by Jaime \
> Torres to branch KDE/4.12.
>
> - Commit Hook
>
> On December 29th, 2013, 9:40 a.m. UTC, Jaime Torres Amate wrote:
> Review request for KDE Games and Roney Gomes.
> By Jaime Torres Amate.
>
> *Updated Dec. 29, 2013, 9:40 a.m.*
> *Bugs: * 168657 <http://bugs.kde.org/show_bug.cgi?id=168657>
> *Repository: * knavalbattle
> Description
>
> This patch includes the work done by Roney in the show-ships branch (my work is only the two \
> phase end of game and the network part).
> How does it accomplishes its purpose?
> * The end game has now two phases, first send/receive the ships in the GameOverMessage, then \
> the end game part.
> * All the entities include a reference to the SeaView to be able to show the ships (included \
> in the parent class Entity)
> * The shoots are drawn over the ships
> * Instead of a parameter, the flag of adjacent ships is now a member (grabbed from the \
> multiple ships patch, to be released soon).
> * The ships have now the coordinates where they are.
> * The GameOverMessage was already ready to send/receive ships (with a little bug fixed).
> * Grid now has a copy constructor
> * Changed the name of a variable from a confusing name m_sea to a more clear m_seaview
> * There are now two lists of ships (for both entities to be able to interchange the ships)
>
> * It does not include configuration for this functionality, I think everybody expects this \
> behavior from this kind of game.
> Testing
>
> It works with the several ships patch (in every possible combination) and as it is, tested \
> several times in local and remote games.
> Diffs
>
> - src/ai/dummyai.cpp (2cae8d5)
> - src/ai/smartai.cpp (121d2de)
> - src/aientity.h (d8d3ade)
> - src/aientity.cpp (a7f9bca)
> - src/battlefield.h (83d8f5f)
> - src/battlefield.cpp (690bf93)
> - src/battlefieldview.h (aaec342)
> - src/battlefieldview.cpp (233f1e4)
> - src/controller.h (e87ba48)
> - src/controller.cpp (23b8153)
> - src/coord.h (32dd8c0)
> - src/entity.h (4955a81)
> - src/entity.cpp (067e384)
> - src/networkentity.h (ae97522)
> - src/networkentity.cpp (9f252ca)
> - src/playerentity.cpp (9c32b25)
> - src/playfield.h (6a24657)
> - src/playfield.cpp (f1d774b)
> - src/protocol.cpp (152c9cd)
> - src/sea.h (e9e7333)
> - src/sea.cpp (51f4f0c)
> - src/seaview.h (df22a21)
> - src/seaview.cpp (92d6e4e)
> - src/ship.h (f52fa95)
> - src/ship.cpp (cf78535)
> - src/simplemenu.cpp (cf5684d)
> - src/uientity.h (fa92a90)
> - src/uientity.cpp (bca8ac9)
>
> View Diff <https://git.reviewboard.kde.org/r/114620/diff/>
>
[Attachment #5 (text/html)]
<div dir="ltr">I'm sorry, the review closed is the other one, I've copied/pasted the \
wrong number. This one is still open.<br></div><div class="gmail_extra"><br><br><div \
class="gmail_quote">2013/12/29 Commit Hook <span dir="ltr"><<a href="mailto:null@kde.org" \
target="_blank">null@kde.org</a>></span><br> <blockquote class="gmail_quote" style="margin:0 \
0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>
<div style="font-family:Verdana,Arial,Helvetica,Sans-Serif"><div class="im">
<table style="border:1px #c9c399 solid" bgcolor="#f9f3c9" cellpadding="8" width="100%">
<tbody><tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/114620/" \
target="_blank">https://git.reviewboard.kde.org/r/114620/</a> </td>
</tr>
</tbody></table>
<br>
</div><pre style="white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This \
review has been submitted with commit df86bb2e2480f5b737b113f51a56638638e6201d by Jaime Torres \
to branch KDE/4.12.</pre> <span class="HOEnZb"><font color="#888888">
<br>
<p>- Commit Hook</p></font></span><div><div class="h5">
<br>
<p>On December 29th, 2013, 9:40 a.m. UTC, Jaime Torres Amate wrote:</p>
<table style="background-image:url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png');background-repeat:repeat-x;border:1px \
black solid" bgcolor="#fefadf" cellpadding="8" cellspacing="0" width="100%">
<tbody><tr>
<td>
<div>Review request for KDE Games and Roney Gomes.</div>
<div>By Jaime Torres Amate.</div>
<p style="color:grey"><i>Updated Dec. 29, 2013, 9:40 a.m.</i></p>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt;margin-top:1.5em">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=168657" target="_blank">168657</a>
</div>
<div style="margin-top:1.5em">
<b style="color:#575012;font-size:10pt">Repository: </b>
knavalbattle
</div>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Description </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" \
width="100%"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">This \
patch includes the work done by Roney in the show-ships branch (my work is only the two phase \
end of game and the network part).
How does it accomplishes its purpose?
* The end game has now two phases, first send/receive the ships in the GameOverMessage, then \
the end game part.
* All the entities include a reference to the SeaView to be able to show the ships (included in \
the parent class Entity)
* The shoots are drawn over the ships
* Instead of a parameter, the flag of adjacent ships is now a member (grabbed from the multiple \
ships patch, to be released soon).
* The ships have now the coordinates where they are.
* The GameOverMessage was already ready to send/receive ships (with a little bug fixed).
* Grid now has a copy constructor
* Changed the name of a variable from a confusing name m_sea to a more clear m_seaview
* There are now two lists of ships (for both entities to be able to interchange the ships)
* It does not include configuration for this functionality, I think everybody expects this \
behavior from this kind of game. </pre> </td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Testing </h1>
<table style="border:1px solid #b8b5a0" bgcolor="#ffffff" cellpadding="10" cellspacing="0" \
width="100%"> <tbody><tr>
<td>
<pre style="margin:0;padding:0;white-space:pre-wrap;white-space:-moz-pre-wrap;white-space:-pre-wrap;white-space:-o-pre-wrap;word-wrap:break-word">It \
works with the several ships patch (in every possible combination) and as it is, tested several \
times in local and remote games.</pre>
</td>
</tr>
</tbody></table>
<h1 style="color:#575012;font-size:10pt;margin-top:1.5em">Diffs </h1>
<ul style="margin-left:3em;padding-left:0">
<li>src/ai/dummyai.cpp <span style="color:grey">(2cae8d5)</span></li>
<li>src/ai/smartai.cpp <span style="color:grey">(121d2de)</span></li>
<li>src/aientity.h <span style="color:grey">(d8d3ade)</span></li>
<li>src/aientity.cpp <span style="color:grey">(a7f9bca)</span></li>
<li>src/battlefield.h <span style="color:grey">(83d8f5f)</span></li>
<li>src/battlefield.cpp <span style="color:grey">(690bf93)</span></li>
<li>src/battlefieldview.h <span style="color:grey">(aaec342)</span></li>
<li>src/battlefieldview.cpp <span style="color:grey">(233f1e4)</span></li>
<li>src/controller.h <span style="color:grey">(e87ba48)</span></li>
<li>src/controller.cpp <span style="color:grey">(23b8153)</span></li>
<li>src/coord.h <span style="color:grey">(32dd8c0)</span></li>
<li>src/entity.h <span style="color:grey">(4955a81)</span></li>
<li>src/entity.cpp <span style="color:grey">(067e384)</span></li>
<li>src/networkentity.h <span style="color:grey">(ae97522)</span></li>
<li>src/networkentity.cpp <span style="color:grey">(9f252ca)</span></li>
<li>src/playerentity.cpp <span style="color:grey">(9c32b25)</span></li>
<li>src/playfield.h <span style="color:grey">(6a24657)</span></li>
<li>src/playfield.cpp <span style="color:grey">(f1d774b)</span></li>
<li>src/protocol.cpp <span style="color:grey">(152c9cd)</span></li>
<li>src/sea.h <span style="color:grey">(e9e7333)</span></li>
<li>src/sea.cpp <span style="color:grey">(51f4f0c)</span></li>
<li>src/seaview.h <span style="color:grey">(df22a21)</span></li>
<li>src/seaview.cpp <span style="color:grey">(92d6e4e)</span></li>
<li>src/ship.h <span style="color:grey">(f52fa95)</span></li>
<li>src/ship.cpp <span style="color:grey">(cf78535)</span></li>
<li>src/simplemenu.cpp <span style="color:grey">(cf5684d)</span></li>
<li>src/uientity.h <span style="color:grey">(fa92a90)</span></li>
<li>src/uientity.cpp <span style="color:grey">(bca8ac9)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/114620/diff/" style="margin-left:3em" \
target="_blank">View Diff</a></p>
</td>
</tr>
</tbody></table>
</div></div></div>
</div>
</blockquote></div><br></div>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic