[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-games-devel
Subject: Re: [Kde-games-devel] Review Request: List scores according to difficulty
From: "Albert Astals Cid" <tsdgeos () terra ! es>
Date: 2013-01-08 21:42:15
Message-ID: 20130108214215.15699.39070 () vidsolbach ! de
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
http://git.reviewboard.kde.org/r/108269/#review25010
-----------------------------------------------------------
Hi Jack, the code looks good, i will need your full name and email address so we can \
give you proper credit when commiting the fix.
- Albert Astals Cid
On Jan. 8, 2013, 5:26 p.m., jack daniel wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> http://git.reviewboard.kde.org/r/108269/
> -----------------------------------------------------------
>
> (Updated Jan. 8, 2013, 5:26 p.m.)
>
>
> Review request for KDE Games.
>
>
> Description
> -------
>
> Try to add scores to the correct difficulty level.
>
> Someone posted a patch at bugs.kde.org, but that seems to add the score to the next \
> level higher than that played.
> KExtHighscore::setGameType() seems to add scores from level 0 up.
>
>
> This addresses bug 305661.
> http://bugs.kde.org/show_bug.cgi?id=305661
>
>
> Diffs
> -----
>
> mainwindow.cpp 47d7826
>
> Diff: http://git.reviewboard.kde.org/r/108269/diff/
>
>
> Testing
> -------
>
> Lost a few games at different levels. Looks OK.
>
>
> Thanks,
>
> jack daniel
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="http://git.reviewboard.kde.org/r/108269/">http://git.reviewboard.kde.org/r/108269/</a>
</td>
</tr>
</table>
<br />
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hi Jack, the code looks \
good, i will need your full name and email address so we can give you proper credit \
when commiting the fix.</pre> <br />
<p>- Albert</p>
<br />
<p>On January 8th, 2013, 5:26 p.m., jack daniel wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('http://git.reviewboard.kde.org/media/rb/images/review_request_box_top_bg.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Games.</div>
<div>By jack daniel.</div>
<p style="color: grey;"><i>Updated Jan. 8, 2013, 5:26 p.m.</i></p>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Try to add scores to the correct difficulty level.
Someone posted a patch at bugs.kde.org, but that seems to add the score to the next \
level higher than that played.
KExtHighscore::setGameType() seems to add scores from level 0 up.</pre>
</td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Lost a few games at different levels. Looks OK.</pre> </td>
</tr>
</table>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=305661">305661</a>
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>mainwindow.cpp <span style="color: grey">(47d7826)</span></li>
</ul>
<p><a href="http://git.reviewboard.kde.org/r/108269/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
kde-games-devel mailing list
kde-games-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-games-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic