--===============8126644033923905607== Content-Type: multipart/alternative; boundary="===============2582892748939057629==" --===============2582892748939057629== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: http://git.reviewboard.kde.org/r/108269/#review25010 ----------------------------------------------------------- Hi Jack, the code looks good, i will need your full name and email address = so we can give you proper credit when commiting the fix. - Albert Astals Cid On Jan. 8, 2013, 5:26 p.m., jack daniel wrote: > = > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > http://git.reviewboard.kde.org/r/108269/ > ----------------------------------------------------------- > = > (Updated Jan. 8, 2013, 5:26 p.m.) > = > = > Review request for KDE Games. > = > = > Description > ------- > = > Try to add scores to the correct difficulty level. > = > Someone posted a patch at bugs.kde.org, but that seems to add the score t= o the next level higher than that played. > = > KExtHighscore::setGameType() seems to add scores from level 0 up. > = > = > This addresses bug 305661. > http://bugs.kde.org/show_bug.cgi?id=3D305661 > = > = > Diffs > ----- > = > mainwindow.cpp 47d7826 = > = > Diff: http://git.reviewboard.kde.org/r/108269/diff/ > = > = > Testing > ------- > = > Lost a few games at different levels. Looks OK. > = > = > Thanks, > = > jack daniel > = > --===============2582892748939057629== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: quoted-printable
This is an automatically generated e-mail. To reply, visit: http://git.revie= wboard.kde.org/r/108269/ |
Hi Jack, t= he code looks good, i will need your full name and email address so we can = give you proper credit when commiting the fix.
- Albert
On January 8th, 2013, 5:26 p.m., jack daniel wrote:
Review request for KDE Games.
By jack daniel.
Updated Jan. 8, 2013, 5:26 p.m. Descripti= on
Testing <= /h1>
Bugs:
305661
Diffs=
|