[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D7584: [Icon Item] Don't needlessly unset imagePath
From:       David Edmundson <noreply () phabricator ! kde ! org>
Date:       2017-08-30 12:06:47
Message-ID: 20170830120644.129722.193045A34F4FA3CF () phabricator ! kde ! org
[Download RAW message or body]

davidedmundson added inline comments.

INLINE COMMENTS

> iconitem.cpp:199
> if (!iconPath.isEmpty()) {
> m_svgIcon->setImagePath(iconPath);
> m_svgIconName = sourceString;

are you saying we'll always hit this one?

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7584

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">davidedmundson added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7584" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7584#inline-31097" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">iconitem.cpp:199</span></div> <div style="font: 11px/15px &quot;Menlo&quot;, \
&quot;Consolas&quot;, &quot;Monaco&quot;, monospace; white-space: pre-wrap; clear: \
both; padding: 4px 0; margin: 0;"><div style="padding: 0 8px; margin: 0 4px; ">       \
<span style="color: #aa4000">if</span> <span class="p">(</span><span style="color: \
#aa2211">!</span><span class="n">iconPath</span><span class="p">.</span><span \
class="n">isEmpty</span><span class="p">())</span> <span class="p">{</span> \
</div><div style="padding: 0 8px; margin: 0 4px; ">                    <span \
class="n">m_svgIcon</span><span style="color: #aa2211">-&gt;</span><span \
class="n">setImagePath</span><span class="p">(</span><span \
class="n">iconPath</span><span class="p">);</span> </div><div style="padding: 0 8px; \
margin: 0 4px; ">                    <span class="n">m_svgIconName</span> <span \
style="color: #aa2211">=</span> <span class="n">sourceString</span><span \
class="p">;</span> </div></div></div>
<div style="margin: 8px 0; padding: 0 12px;"><p style="padding: 0; margin: 8px;">are \
you saying we&#039;ll always hit this one?</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7584" \
rel="noreferrer">https://phabricator.kde.org/D7584</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]