[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D7584: [Icon Item] Don't needlessly unset imagePath
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-08-30 12:12:52
Message-ID: 20170830121200.119151.27F216E1281DE1C6 () phabricator ! kde ! org
[Download RAW message or body]

broulik added inline comments.

INLINE COMMENTS

> davidedmundson wrote in iconitem.cpp:199
> are you saying we'll always hit this one?

If we use plasma theme and have valid icon (line 176 does set image path and 181 \
checks for validity if plasmatheme).

If we dont have a plasma theme or failedto load the image in line 176, then we'll try \
iconloader. if that works, we'll use that. (this line). If that also didn't work \
we'll dispose of the svgIcon.

I don't see a way where we would end up with the old m_svgIcon still being used.

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7584

To: broulik, #plasma
Cc: davidedmundson, plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, \
ali-mohamed, jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">broulik added inline comments.
</td><a style="text-decoration: none; padding: 4px 8px; margin: 0 8px 8px; float: \
right; color: #464C5C; font-weight: bold; border-radius: 3px; background-color: \
#F7F7F9; background-image: linear-gradient(to bottom,#fff,#f1f0f1); display: \
inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7584" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>INLINE COMMENTS</strong><div><div \
style="margin: 6px 0 12px 0;"><div style="border: 1px solid #C7CCD9; border-radius: \
3px;"><div style="padding: 0; background: #F7F7F7; border-color: #e3e4e8; \
border-style: solid; border-width: 0 0 1px 0; margin: 0;"><div style="color: #74777d; \
background: #eff2f4; padding: 6px 8px; overflow: hidden;"><a style="float: right; \
text-decoration: none;" href="https://phabricator.kde.org/D7584#inline-31097" \
rel="noreferrer">View Inline</a><span style="color: #4b4d51; font-weight: \
bold;">davidedmundson</span> wrote in <span style="color: #4b4d51; font-weight: \
bold;">iconitem.cpp:199</span></div> <div style="margin: 8px 0; padding: 0 12px; \
color: #74777D;"><p style="padding: 0; margin: 8px;">are you saying we&#039;ll always \
hit this one?</p></div></div> <div style="margin: 8px 0; padding: 0 12px;"><p \
style="padding: 0; margin: 8px;">If we use plasma theme and have valid icon (line 176 \
does set image path and 181 checks for validity if plasmatheme).</p>

<p style="padding: 0; margin: 8px;">If we dont have a plasma theme or failedto load \
the image in line 176, then we&#039;ll try iconloader. if that works, we&#039;ll use \
that. (this line). If that also didn&#039;t work we&#039;ll dispose of the \
svgIcon.</p>

<p style="padding: 0; margin: 8px;">I don&#039;t see a way where we would end up with \
the old m_svgIcon still being used.</p></div></div></div></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7584" \
rel="noreferrer">https://phabricator.kde.org/D7584</a></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>davidedmundson, \
plasma-devel, Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]