[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    D7584: [Icon Item] Don't needlessly unset imagePath
From:       Kai Uwe Broulik <noreply () phabricator ! kde ! org>
Date:       2017-08-28 14:09:53
Message-ID: differential-rev-PHID-DREV-7f3v2qizkx7gfcopzqyo-req () phabricator ! kde ! org
[Download RAW message or body]

broulik created this revision.
Restricted Application added projects: Plasma, Frameworks.
Restricted Application added subscribers: Frameworks, plasma-devel.

REVISION SUMMARY
  We'll eventually delete the Plasma::Svg anyway if we failed to find an appropriate \
icon.  Just need to make sure we don't use isValid with the old source set but this \
is only done with m_usesPlasmaTheme, hence the new check there, also optimizes the \
non-themed case.

TEST PLAN
  Test still passes, I no longer see setImagePath being called with empty string 400 \
times on startup

REPOSITORY
  R242 Plasma Framework (Library)

REVISION DETAIL
  https://phabricator.kde.org/D7584

AFFECTED FILES
  src/declarativeimports/core/iconitem.cpp

To: broulik, #plasma
Cc: plasma-devel, #frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, \
jensreuterberg, abetts, sebas, apol, mart, lukas


[Attachment #3 (unknown)]

<table><tr><td style="">broulik created this revision.<br />Restricted Application \
added projects: Plasma, Frameworks.<br />Restricted Application added subscribers: \
Frameworks, plasma-devel. </td><a style="text-decoration: none; padding: 4px 8px; \
margin: 0 8px 8px; float: right; color: #464C5C; font-weight: bold; border-radius: \
3px; background-color: #F7F7F9; background-image: linear-gradient(to \
bottom,#fff,#f1f0f1); display: inline-block; border: 1px solid rgba(71,87,120,.2);" \
href="https://phabricator.kde.org/D7584" rel="noreferrer">View \
Revision</a></tr></table><br /><div><strong>REVISION \
SUMMARY</strong><div><p>We&#039;ll eventually delete the Plasma::Svg anyway if we \
failed to find an appropriate icon.<br /> Just need to make sure we don&#039;t use \
isValid with the old source set but this is only done with m_usesPlasmaTheme, hence \
the new check there, also optimizes the non-themed case.</p></div></div><br \
/><div><strong>TEST PLAN</strong><div><p>Test still passes, I no longer see \
setImagePath being called with empty string 400 times on startup</p></div></div><br \
/><div><strong>REPOSITORY</strong><div><div>R242 Plasma Framework \
(Library)</div></div></div><br /><div><strong>REVISION DETAIL</strong><div><a \
href="https://phabricator.kde.org/D7584" \
rel="noreferrer">https://phabricator.kde.org/D7584</a></div></div><br \
/><div><strong>AFFECTED \
FILES</strong><div><div>src/declarativeimports/core/iconitem.cpp</div></div></div><br \
/><div><strong>To: </strong>broulik, Plasma<br /><strong>Cc: </strong>plasma-devel, \
Frameworks, ZrenBot, progwolff, lesliezhai, ali-mohamed, jensreuterberg, abetts, \
sebas, apol, mart, lukas<br /></div>



[prev in list] [next in list] [prev in thread] [next in thread]