'Re: Review Request 126696: kssld: install DBus service file for org.kde.kssld5'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126696: kssld: install DBus service file for org.kde.kssld5
From:       "David Faure" <faure () kde ! org>
Date:       2016-01-12 8:12:25
Message-ID: 20160112081225.23702.44296 () mimi ! kde ! org
[Download RAW message or body]

--===============2210745138404541805==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126696/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 8:12 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks.

Changes
-------

Submitted with commit 8624f1128fc434485ba6302c0be4b75e4f0de649 by David Faure to \
branch master.

Repository: kio

Description
-------

The only caller is ksslcertificatemanager but this is more consistent with
what was done for kpasswdserver, and future kiod modules.

This is basically an improved fix for https://git.reviewboard.kde.org/r/122606/ \
(committed some time ago)

Diffs
-----

  src/core/ksslcertificatemanager.cpp 4efdf4df95b1e1351b772fd50396141f57a12a3d 
  src/kssld/CMakeLists.txt 5029d83951d845c6c96da00397932246ac5617a4 
  src/kssld/org.kde.kssld5.service.in PRE-CREATION 

Diff: https://git.reviewboard.kde.org/r/126696/diff/

Testing
-------

`qdbus org.kde.kssld5 /modules/kssld` works even if kiod isn't running yet.

Thanks,

David Faure

--===============2210745138404541805==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126696/">https://git.reviewboard.kde.org/r/126696/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By David Faure.</div>

<p style="color: grey;"><i>Updated Jan. 12, 2016, 8:12 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 8624f1128fc434485ba6302c0be4b75e4f0de649 by David \
Faure to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">The only caller is ksslcertificatemanager but this is \
more consistent with what was done for kpasswdserver, and future kiod modules.</p>
<p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">This is basically an improved fix for \
https://git.reviewboard.kde.org/r/122606/ (committed some time ago)</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">qdbus \
org.kde.kssld5 /modules/kssld</code> works even if kiod isn't running yet.</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/core/ksslcertificatemanager.cpp <span style="color: \
grey">(4efdf4df95b1e1351b772fd50396141f57a12a3d)</span></li>

 <li>src/kssld/CMakeLists.txt <span style="color: \
grey">(5029d83951d845c6c96da00397932246ac5617a4)</span></li>

 <li>src/kssld/org.kde.kssld5.service.in <span style="color: \
grey">(PRE-CREATION)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126696/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============2210745138404541805==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 