'Re: Review Request 126712: Make kcookiejar accessible under the dbus service name org.kde.kcookiejar'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 126712: Make kcookiejar accessible under the dbus service name org.kde.kcookiejar
From:       "David Faure" <faure () kde ! org>
Date:       2016-01-12 8:12:41
Message-ID: 20160112081241.23702.11627 () mimi ! kde ! org
[Download RAW message or body]

--===============8806243127394292890==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/126712/
-----------------------------------------------------------

(Updated Jan. 12, 2016, 8:12 a.m.)

Status
------

This change has been marked as submitted.

Review request for KDE Frameworks.

Changes
-------

Submitted with commit 8c81f8b052da5366515e5736c7b22c771501510a by David Faure to \
branch master.

Repository: kio

Description
-------

This will make it possible to move it away from kded one day.

Change-Id: Id575eb7a75d26ee9fd74ce77ade5fad862869154

Diffs
-----

  src/ioslaves/http/http.cpp 76c4f3d287638fd1624fc0297318485c07931a49 
  src/ioslaves/http/kcookiejar/CMakeLists.txt \
8489a0aed9312271cb339543909f843ec58f44a0   \
src/ioslaves/http/kcookiejar/kcookiejar.json a2653d98633f6d6311288d7e2678813045e5f9d2 \
  src/ioslaves/http/kcookiejar/main.cpp fbc61cba9e1b8b0bde2f7fbc5a5e3796db1e0fe0 
  src/ioslaves/http/kcookiejar/org.kde.kcookiejar5.service.in PRE-CREATION 
  src/kcms/kio/kcookiesmain.cpp a418fd3237a0c2cfb4845ee1e63ecb875e564c5f 
  src/kcms/kio/kcookiesmanagement.cpp ba74cc7081b819fa0f1d38f9ffec30d6e574af02 
  src/kcms/kio/kcookiespolicies.cpp b0b7a1c80cdd439bf77686a22c9af51053ad42b4 
  src/kcms/kio/ksaveioconfig.cpp 537800cea533887f4b0d15baef0fafe79150b649 
  src/widgets/accessmanager.cpp 37651cf5173dbf43cbfb4d01df367ab2caede26b 

Diff: https://git.reviewboard.kde.org/r/126712/diff/

Testing
-------

`qdbus org.kde.kcookiejar5 /modules/kcookiejar` now works, even if kded5 isn't \
running yet (after fixing the autoload settings that \
https://git.reviewboard.kde.org/r/125048/ modified, I think by mistake)

Thanks,

David Faure

--===============8806243127394292890==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/126712/">https://git.reviewboard.kde.org/r/126712/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#e0e0e0" width="100%" cellpadding="12" style="border: 1px gray solid; \
border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  <tr>
  <td>
   <h1 style="margin: 0; padding: 0; font-size: 10pt;">This change has been marked as \
submitted.</h1>  </td>
 </tr>
</table>
<br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By David Faure.</div>

<p style="color: grey;"><i>Updated Jan. 12, 2016, 8:12 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Submitted with commit 8c81f8b052da5366515e5736c7b22c771501510a by David \
Faure to branch master.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kio
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This will make it possible to move it away from kded one day.

Change-Id: Id575eb7a75d26ee9fd74ce77ade5fad862869154</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;"><code style="text-rendering: inherit;color: \
#4444cc;padding: 0;white-space: normal;margin: 0;line-height: inherit;">qdbus \
org.kde.kcookiejar5 /modules/kcookiejar</code> now works, even if kded5 isn't running \
yet (after fixing the autoload settings that \
https://git.reviewboard.kde.org/r/125048/ modified, I think by mistake)</p></pre>  \
</td>  </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/ioslaves/http/http.cpp <span style="color: \
grey">(76c4f3d287638fd1624fc0297318485c07931a49)</span></li>

 <li>src/ioslaves/http/kcookiejar/CMakeLists.txt <span style="color: \
grey">(8489a0aed9312271cb339543909f843ec58f44a0)</span></li>

 <li>src/ioslaves/http/kcookiejar/kcookiejar.json <span style="color: \
grey">(a2653d98633f6d6311288d7e2678813045e5f9d2)</span></li>

 <li>src/ioslaves/http/kcookiejar/main.cpp <span style="color: \
grey">(fbc61cba9e1b8b0bde2f7fbc5a5e3796db1e0fe0)</span></li>

 <li>src/ioslaves/http/kcookiejar/org.kde.kcookiejar5.service.in <span style="color: \
grey">(PRE-CREATION)</span></li>

 <li>src/kcms/kio/kcookiesmain.cpp <span style="color: \
grey">(a418fd3237a0c2cfb4845ee1e63ecb875e564c5f)</span></li>

 <li>src/kcms/kio/kcookiesmanagement.cpp <span style="color: \
grey">(ba74cc7081b819fa0f1d38f9ffec30d6e574af02)</span></li>

 <li>src/kcms/kio/kcookiespolicies.cpp <span style="color: \
grey">(b0b7a1c80cdd439bf77686a22c9af51053ad42b4)</span></li>

 <li>src/kcms/kio/ksaveioconfig.cpp <span style="color: \
grey">(537800cea533887f4b0d15baef0fafe79150b649)</span></li>

 <li>src/widgets/accessmanager.cpp <span style="color: \
grey">(37651cf5173dbf43cbfb4d01df367ab2caede26b)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/126712/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============8806243127394292890==--

[Attachment #3 (text/plain)]

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 