From kde-frameworks-devel Tue Jan 12 08:12:25 2016 From: "David Faure" Date: Tue, 12 Jan 2016 08:12:25 +0000 To: kde-frameworks-devel Subject: Re: Review Request 126696: kssld: install DBus service file for org.kde.kssld5 Message-Id: <20160112081225.23702.44296 () mimi ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-frameworks-devel&m=145258636722751 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============8480027078710237946==" --===============8480027078710237946== Content-Type: multipart/alternative; boundary="===============2210745138404541805==" --===============2210745138404541805== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126696/ ----------------------------------------------------------- (Updated Jan. 12, 2016, 8:12 a.m.) Status ------ This change has been marked as submitted. Review request for KDE Frameworks. Changes ------- Submitted with commit 8624f1128fc434485ba6302c0be4b75e4f0de649 by David Faure to branch master. Repository: kio Description ------- The only caller is ksslcertificatemanager but this is more consistent with what was done for kpasswdserver, and future kiod modules. This is basically an improved fix for https://git.reviewboard.kde.org/r/122606/ (committed some time ago) Diffs ----- src/core/ksslcertificatemanager.cpp 4efdf4df95b1e1351b772fd50396141f57a12a3d src/kssld/CMakeLists.txt 5029d83951d845c6c96da00397932246ac5617a4 src/kssld/org.kde.kssld5.service.in PRE-CREATION Diff: https://git.reviewboard.kde.org/r/126696/diff/ Testing ------- `qdbus org.kde.kssld5 /modules/kssld` works even if kiod isn't running yet. Thanks, David Faure --===============2210745138404541805== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit
This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/126696/

This change has been marked as submitted.

Review request for KDE Frameworks.
By David Faure.

Updated Jan. 12, 2016, 8:12 a.m.

Changes

Submitted with commit 8624f1128fc434485ba6302c0be4b75e4f0de649 by David Faure to branch master.
Repository: kio

Description 

The only caller is ksslcertificatemanager but this is more consistent with
what was done for kpasswdserver, and future kiod modules.


This is basically an improved fix for https://git.reviewboard.kde.org/r/122606/ (committed some time ago)

Testing 

qdbus org.kde.kssld5 /modules/kssld works even if kiod isn't running yet.

Diffs

  • src/core/ksslcertificatemanager.cpp (4efdf4df95b1e1351b772fd50396141f57a12a3d)
  • src/kssld/CMakeLists.txt (5029d83951d845c6c96da00397932246ac5617a4)
  • src/kssld/org.kde.kssld5.service.in (PRE-CREATION)

View Diff
--===============2210745138404541805==-- --===============8480027078710237946== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: base64 Content-Disposition: inline X19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX19fX18KS2RlLWZyYW1l d29ya3MtZGV2ZWwgbWFpbGluZyBsaXN0CktkZS1mcmFtZXdvcmtzLWRldmVsQGtkZS5vcmcKaHR0 cHM6Ly9tYWlsLmtkZS5vcmcvbWFpbG1hbi9saXN0aW5mby9rZGUtZnJhbWV3b3Jrcy1kZXZlbAo= --===============8480027078710237946==--