'Re: Review Request 119323: fix auth race condition'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 119323: fix auth race condition
From:       "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date:       2014-07-16 16:18:21
Message-ID: 20140716161821.32551.45122 () probe ! kde ! org
[Download RAW message or body]

--===============6354661496156049746==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit

> On July 16, 2014, 6:06 p.m., Luca Beltrame wrote:
> > I ran the (few) autotests, and those also pass. I can't test it runtime, will do \
> > so later hopefully.

a few runtime checks (e.g. org.kde.powerdevil.backlighthelper) seem to work =)

also polkit reports system-bus-name is used

- Hrvoje

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119323/#review62520
-----------------------------------------------------------

On July 16, 2014, 6:05 p.m., Martin Tobias Holmedahl Sandsmark wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119323/
> -----------------------------------------------------------
> 
> (Updated July 16, 2014, 6:05 p.m.)
> 
> 
> Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin \
> Bříza. 
> 
> Repository: kauth
> 
> 
> Description
> -------
> 
> pid based auth is racy because of pid reuse, don't use it.
> 
> 
> Diffs
> -----
> 
> src/backends/polkit-1/Polkit1Backend.cpp 165f7bb 
> 
> Diff: https://git.reviewboard.kde.org/r/119323/diff/
> 
> 
> Testing
> -------
> 
> it builds
> 
> 
> Thanks,
> 
> Martin Tobias Holmedahl Sandsmark
> 
> 

--===============6354661496156049746==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/119323/">https://git.reviewboard.kde.org/r/119323/</a>
  </td>
    </tr>
   </table>
   <br />

<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;">  <p style="margin-top: 0;">On July 16th, 2014, 6:06 p.m. CEST, <b>Luca \
Beltrame</b> wrote:</p>  <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">  <pre style="white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">I ran the (few) autotests, and those also pass. I \
can't test it runtime, will do so later hopefully.</p></pre>  </blockquote>

</blockquote>

<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">a few \
runtime checks (e.g. org.kde.powerdevil.backlighthelper) seem to work =)</p> <p \
style="padding: 0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: \
inherit;">also polkit reports system-bus-name is used</p></pre> <br />

<p>- Hrvoje</p>

<br />
<p>On July 16th, 2014, 6:05 p.m. CEST, Martin Tobias Holmedahl Sandsmark wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin \
Bříza.</div> <div>By Martin Tobias Holmedahl Sandsmark.</div>

<p style="color: grey;"><i>Updated July 16, 2014, 6:05 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kauth
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">pid based auth is racy because of pid reuse, don't use \
it.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">it builds</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/backends/polkit-1/Polkit1Backend.cpp <span style="color: \
grey">(165f7bb)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/119323/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============6354661496156049746==--

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 