[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 119323: fix auth race condition
From: "Hrvoje Senjan" <hrvoje.senjan () gmail ! com>
Date: 2014-07-17 5:39:15
Message-ID: 20140717053915.32551.28679 () probe ! kde ! org
[Download RAW message or body]
--===============1455101456625343981==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 8bit
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/119323/#review62546
-----------------------------------------------------------
src/backends/polkit-1/Polkit1Backend.cpp
<https://git.reviewboard.kde.org/r/119323/#comment43392>
i guess we can also have QDBusConnection::systemBus().baseService() here?
- Hrvoje Senjan
On July 16, 2014, 6:05 p.m., Martin Tobias Holmedahl Sandsmark wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/119323/
> -----------------------------------------------------------
>
> (Updated July 16, 2014, 6:05 p.m.)
>
>
> Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin \
> Bříza.
>
> Repository: kauth
>
>
> Description
> -------
>
> pid based auth is racy because of pid reuse, don't use it.
>
>
> Diffs
> -----
>
> src/backends/polkit-1/Polkit1Backend.cpp 165f7bb
>
> Diff: https://git.reviewboard.kde.org/r/119323/diff/
>
>
> Testing
> -------
>
> it builds
>
>
> Thanks,
>
> Martin Tobias Holmedahl Sandsmark
>
>
--===============1455101456625343981==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 8bit
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;"> \
<tr> <td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/119323/">https://git.reviewboard.kde.org/r/119323/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/119323/diff/1/?file=290639#file290639line145" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/backends/polkit-1/Polkit1Backend.cpp</a> <span style="font-weight: \
normal;">
(Diff revision 1)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; \
">Action::AuthStatus Polkit1Backend::actionStatus(const QString \
&action)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#f0f0f0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">145</font></th> <td bgcolor="#ffffff" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="n">PolkitQt1</span><span class="o">::</span><span \
class="n">UnixProcessSubject</span> <span class="n">subject</span><span \
class="p">(</span><span class="n">QCoreApplication</span><span \
class="o">::</span><span class="n">applicationPid</span><span \
class="p">());</span></pre></td> <th bgcolor="#f0f0f0" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">145</font></th> <td bgcolor="#ffffff" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "> <span class="n">PolkitQt1</span><span \
class="o">::</span><span class="n">UnixProcessSubject</span> <span \
class="n">subject</span><span class="p">(</span><span \
class="n">QCoreApplication</span><span class="o">::</span><span \
class="n">applicationPid</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<div style="margin-left: 2em;">
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">i \
guess we can also have QDBusConnection::systemBus().baseService() here?</p></pre> \
</div> </div>
<br />
<p>- Hrvoje Senjan</p>
<br />
<p>On July 16th, 2014, 6:05 p.m. CEST, Martin Tobias Holmedahl Sandsmark wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;"> <tr>
<td>
<div>Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin \
Bříza.</div> <div>By Martin Tobias Holmedahl Sandsmark.</div>
<p style="color: grey;"><i>Updated July 16, 2014, 6:05 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kauth
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">pid based auth is racy because of pid reuse, don't use \
it.</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">it builds</p></pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/backends/polkit-1/Polkit1Backend.cpp <span style="color: \
grey">(165f7bb)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/119323/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
--===============1455101456625343981==--
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic