--===============7663030870751617120== Content-Type: multipart/alternative; boundary="===============6354661496156049746==" --===============6354661496156049746== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 8bit > On July 16, 2014, 6:06 p.m., Luca Beltrame wrote: > > I ran the (few) autotests, and those also pass. I can't test it runtime, will do so later hopefully. a few runtime checks (e.g. org.kde.powerdevil.backlighthelper) seem to work =) also polkit reports system-bus-name is used - Hrvoje ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/#review62520 ----------------------------------------------------------- On July 16, 2014, 6:05 p.m., Martin Tobias Holmedahl Sandsmark wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/119323/ > ----------------------------------------------------------- > > (Updated July 16, 2014, 6:05 p.m.) > > > Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin Bříza. > > > Repository: kauth > > > Description > ------- > > pid based auth is racy because of pid reuse, don't use it. > > > Diffs > ----- > > src/backends/polkit-1/Polkit1Backend.cpp 165f7bb > > Diff: https://git.reviewboard.kde.org/r/119323/diff/ > > > Testing > ------- > > it builds > > > Thanks, > > Martin Tobias Holmedahl Sandsmark > > --===============6354661496156049746== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 8bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/119323/

On July 16th, 2014, 6:06 p.m. CEST, Luca Beltrame wrote:
I ran the (few) autotests, and those also pass. I can't test it runtime, will do so later hopefully.

a few runtime checks (e.g. org.kde.powerdevil.backlighthelper) seem to work =)
also polkit reports system-bus-name is used

- Hrvoje

On July 16th, 2014, 6:05 p.m. CEST, Martin Tobias Holmedahl Sandsmark wrote:

Review request for KDE Frameworks, Hrvoje Senjan, Luca Beltrame, and Martin Bříza.

By Martin Tobias Holmedahl Sandsmark.

Updated July 16, 2014, 6:05 p.m.

Repository: kauth

Description

pid based auth is racy because of pid reuse, don't use it.

Testing

it builds

Diffs

src/backends/polkit-1/Polkit1Backend.cpp (165f7bb)

View Diff

--===============6354661496156049746==-- --===============7663030870751617120== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============7663030870751617120==--