--===============4539155171607939786== Content-Type: multipart/alternative; boundary="===============3283305865649641594==" --===============3283305865649641594== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/ ----------------------------------------------------------- (Updated May 3, 2014, 4:38 p.m.) Review request for KDE Frameworks. Changes ------- Handle default case in KDEPlatformFileDialog::setFileMode. Also renamed tests from only testSetMode to testSetFileMode. Repository: frameworkintegration Description ------- This implements support for QFileDialog::setFileMode. Obsolete value QFileDialog::DirectoryOnly is ignored. Autotest was added to test all FileModes. Diffs (updated) ----- autotests/kfiledialog_unittest.cpp 69d474c src/platformtheme/kdeplatformfiledialoghelper.h c59bee9 src/platformtheme/kdeplatformfiledialoghelper.cpp 777d818 Diff: https://git.reviewboard.kde.org/r/117976/diff/ Testing ------- The file dialog works as expected, autotests pass. Thanks, David Rosca --===============3283305865649641594== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117976/

Review request for KDE Frameworks.

By David Rosca.

Updated May 3, 2014, 4:38 p.m.

Changes

Handle default case in KDEPlatformFileDialog::setFileMode.
Also renamed tests from only testSetMode to testSetFileMode.

Repository: frameworkintegration

Description

This implements support for QFileDialog::setFileMode.
Obsolete value QFileDialog::DirectoryOnly is ignored.

Autotest was added to test all FileModes.

Testing

The file dialog works as expected, autotests pass.

Diffs (updated)

autotests/kfiledialog_unittest.cpp (69d474c)
src/platformtheme/kdeplatformfiledialoghelper.h (c59bee9)
src/platformtheme/kdeplatformfiledialoghelper.cpp (777d818)

View Diff

--===============3283305865649641594==-- --===============4539155171607939786== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline _______________________________________________ Kde-frameworks-devel mailing list Kde-frameworks-devel@kde.org https://mail.kde.org/mailman/listinfo/kde-frameworks-devel --===============4539155171607939786==--