'Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData
From:       "Aleix Pol Gonzalez" <aleixpol () kde ! org>
Date:       2014-03-04 23:11:01
Message-ID: 20140304231101.28039.89600 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/
-----------------------------------------------------------

(Updated March 4, 2014, 11:11 p.m.)

Review request for KDE Frameworks.

Changes
-------

Address David's remarks.

I'm a noob. >.<

Repository: kcoreaddons

Description
-------

Let the KAboutData set information to QApplication. This way we don't have to \
duplicate information by passing it to the KAboutData _and_ the QApplication.

Diffs (updated)
-----

  src/lib/kaboutdata.h 2222c9e 
  src/lib/kaboutdata.cpp c347521 

Diff: https://git.reviewboard.kde.org/r/115207/diff/

Testing
-------

Thanks,

Aleix Pol Gonzalez

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/115207/">https://git.reviewboard.kde.org/r/115207/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated March 4, 2014, 11:11 p.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Address David&#39;s remarks.

I&#39;m a noob. &gt;.&lt;</pre>
  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Let the KAboutData set information to QApplication. This way we \
don&#39;t have to duplicate information by passing it to the KAboutData _and_ the \
QApplication.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/lib/kaboutdata.h <span style="color: grey">(2222c9e)</span></li>

 <li>src/lib/kaboutdata.cpp <span style="color: grey">(c347521)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/115207/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 