'Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-frameworks-devel
Subject:    Re: Review Request 116603: Expose the QDialogButtonBox in KPasswordDialog
From:       "Christoph Feck" <christoph () maxiom ! de>
Date:       2014-03-04 23:13:18
Message-ID: 20140304231318.4331.25690 () probe ! kde ! org
[Download RAW message or body]

[Attachment #2 (multipart/alternative)]

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/116603/#review51992
-----------------------------------------------------------

Ship it!

Should this remain internal API? If yes, please mark it as such. If not, please add \
some documentation.

- Christoph Feck

On March 4, 2014, 11:05 p.m., Aleix Pol Gonzalez wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/116603/
> -----------------------------------------------------------
> 
> (Updated March 4, 2014, 11:05 p.m.)
> 
> 
> Review request for KDE Frameworks.
> 
> 
> Repository: kwidgetsaddons
> 
> 
> Description
> -------
> 
> KPasswordDialog used to be a KDialog. There, users could interact with the buttons \
> setup (like sudlg.cpp in kde-runtime/kdesu). The fact that it was re-based to \
> QDialog, we lost the ability of editing the buttons at all. 
> This change exposes the buttonBox(), so the user re-gains this feature, through \
> QDialogButtonBox. 
> 
> Diffs
> -----
> 
> src/kpassworddialog.h 069e301 
> src/kpassworddialog.cpp cacf31a 
> 
> Diff: https://git.reviewboard.kde.org/r/116603/diff/
> 
> 
> Testing
> -------
> 
> Ported sudlg.cpp to it, they need it because it requires an "Ignore" button over \
> there. 
> 
> Thanks,
> 
> Aleix Pol Gonzalez
> 
> 

[Attachment #5 (text/html)]

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;">  <tr>
     <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/116603/">https://git.reviewboard.kde.org/r/116603/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Should this remain \
internal API? If yes, please mark it as such. If not, please add some \
documentation.</pre>  <br />

<p>- Christoph Feck</p>

<br />
<p>On March 4th, 2014, 11:05 p.m. UTC, Aleix Pol Gonzalez wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;">  <tr>
  <td>

<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>

<p style="color: grey;"><i>Updated March 4, 2014, 11:05 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kwidgetsaddons
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">KPasswordDialog used to be a KDialog. There, users could interact with \
the buttons setup (like sudlg.cpp in kde-runtime/kdesu). The fact that it was \
re-based to QDialog, we lost the ability of editing the buttons at all.

This change exposes the buttonBox(), so the user re-gains this feature, through \
QDialogButtonBox.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Ported sudlg.cpp to it, they need it because it requires an \
&quot;Ignore&quot; button over there.</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/kpassworddialog.h <span style="color: grey">(069e301)</span></li>

 <li>src/kpassworddialog.cpp <span style="color: grey">(cacf31a)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/116603/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel

[prev in list] [next in list] [prev in thread] [next in thread] 