[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-frameworks-devel
Subject: Re: Review Request 115207: Improve integration QCommandLineParser <-> KAboutData
From: "Kevin Ottens" <ervin () kde ! org>
Date: 2014-03-04 20:21:23
Message-ID: 20140304202123.28039.39075 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On Feb. 22, 2014, 9:09 a.m., David Faure wrote:
> > src/lib/kaboutdata.cpp, line 919
> > <https://git.reviewboard.kde.org/r/115207/diff/3/?file=245365#file245365line919>
> >
> > A unittest would have shown you the bug in this line...
> > (you're modifying a copy -> no effect).
> >
> > Use setProperty, just like the existing line for applicationIconName does.
> >
> > And then I would remove the inherits() call. It will become a dynamic property if \
> > the app isn't a QGuiApplication, no big deal.
Please address David's comments it's been more than a week.
- Kevin
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/115207/#review50501
-----------------------------------------------------------
On Feb. 21, 2014, 2:03 p.m., Aleix Pol Gonzalez wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/115207/
> -----------------------------------------------------------
>
> (Updated Feb. 21, 2014, 2:03 p.m.)
>
>
> Review request for KDE Frameworks.
>
>
> Repository: kcoreaddons
>
>
> Description
> -------
>
> Let the KAboutData set information to QApplication. This way we don't have to \
> duplicate information by passing it to the KAboutData _and_ the QApplication.
>
> Diffs
> -----
>
> src/lib/kaboutdata.h 2222c9e
> src/lib/kaboutdata.cpp c347521
>
> Diff: https://git.reviewboard.kde.org/r/115207/diff/
>
>
> Testing
> -------
>
>
> Thanks,
>
> Aleix Pol Gonzalez
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/115207/">https://git.reviewboard.kde.org/r/115207/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On February 22nd, 2014, 9:09 a.m. UTC, <b>David \
Faure</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/115207/diff/3/?file=245365#file245365line919" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/lib/kaboutdata.cpp</a> <span style="font-weight: normal;">
(Diff revision 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
KAboutData::setApplicationData(const KAboutData &aboutData)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">919</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> \
<span class="n">app</span><span class="o">-></span><span \
class="n">property</span><span class="p">(</span><span \
class="s">"applicationDisplayName"</span><span class="p">).</span><span \
class="n">setValue</span><span class="p">(</span><span \
class="n">aboutData</span><span class="p">.</span><span \
class="n">displayName</span><span class="p">());</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">A unittest would have \
shown you the bug in this line... (you're modifying a copy -> no effect).
Use setProperty, just like the existing line for applicationIconName does.
And then I would remove the inherits() call. It will become a dynamic property if the \
app isn't a QGuiApplication, no big deal. </pre>
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Please \
address David's comments it's been more than a week.</pre> <br />
<p>- Kevin</p>
<br />
<p>On February 21st, 2014, 2:03 p.m. UTC, Aleix Pol Gonzalez wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for KDE Frameworks.</div>
<div>By Aleix Pol Gonzalez.</div>
<p style="color: grey;"><i>Updated Feb. 21, 2014, 2:03 p.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
kcoreaddons
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Let the KAboutData set information to QApplication. This way we \
don't have to duplicate information by passing it to the KAboutData _and_ the \
QApplication.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/lib/kaboutdata.h <span style="color: grey">(2222c9e)</span></li>
<li>src/lib/kaboutdata.cpp <span style="color: grey">(c347521)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/115207/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
_______________________________________________
Kde-frameworks-devel mailing list
Kde-frameworks-devel@kde.org
https://mail.kde.org/mailman/listinfo/kde-frameworks-devel
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic