[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-docbook
Subject:    Re: using <legalnotice> with something other than FDL
From:       Robby Stephenson <robby () periapsis ! org>
Date:       2011-10-31 4:11:51
Message-ID: 201110302111.51616.robby () periapsis ! org
[Download RAW message or body]

On Sunday 30 October 2011, Burkhard Lück wrote:
> Am Donnerstag, 27. Oktober 2011, 06:19:10 schrieb Robby Stephenson:
> > I would consider that a bug, but is there a workaround? Or does anyone
> > know  why that decision was made? Is there an alternate element for
> > non-FDL licensing info in KDE documentation? Should I try to figure out
> > a patch to change the behavior?
>
> apparently none of the guys inventing this docbook system is around since
> several years.
> 
> My guess is, that at the time the tempalte was written no license except
> GFDL was allowed.
> 
> But because your use case is fully covered by the kde license policy,
> please provide a patch to fix your issue.

The current behavior is to replace the complete contents of the legalnotice 
element with "Legal Notice" and link to the FDL. Attached is a patch which I 
believe maintains the current behavior in the case where the fdl link is in 
the legalnotice text, but shows the legalnotice contents if the fdl link is 
not there. Since just about every KDE doc uses the &FDLNotice; entity, I 
think this should do the trick.

For this specific example for Tellico, I tested this patch and it works. 
Would it be easier to create a ReviewBoard request?

One other thing, the KDE4_CREATE_HANDBOOK macro creates a symlink to the 
common directory in the documentation, but that link only works if the 
documentation gets installed in the same location as the KDE documentation. 
In other words, if I have KDE installed in /usr and I install Tellico's 
documentation in /usr/local, the symlink is broken. I think that's outside 
my knowledge of the cmake magic. Should I just file that as a bug, or is it 
known already?

Thanks everyone,
Robby

["kde-chunk.xsl.diff" (text/x-patch)]

diff --git a/kdoctools/customization/kde-chunk.xsl b/kdoctools/customization/kde-chunk.xsl
index 096de1b..b204d03 100644
--- a/kdoctools/customization/kde-chunk.xsl
+++ b/kdoctools/customization/kde-chunk.xsl
@@ -72,11 +72,22 @@ set       toc,title
   <xsl:variable name="title">
     <xsl:apply-templates select="." mode="title.markup"/>
   </xsl:variable>
-  <p>
-    <a href="{$filename}">
-      <xsl:copy-of select="$title"/>
-    </a>
-  </p>
+  <!-- Hard-coding the GNU FDL is not appropriate, but for backward compatability,
+       if the text in the legalnotice is the FDL notice, then just show the
+       "Legal Notice" text, as KDE4 has done from very early.
+       Otherwise, continue to process the contents of the legalnotice  element -->
+  <xsl:choose>
+     <xsl:when test=".//xref[@linkend='gnu-fdl']">
+      <p>
+        <a href="{$filename}">
+          <xsl:copy-of select="$title"/>
+        </a>
+      </p>
+    </xsl:when>
+    <xsl:otherwise>
+      <xsl:apply-templates select="*"/>
+    </xsl:otherwise>
+  </xsl:choose>
 </xsl:template>
 
 <!-- try with olinks: it nearly works --><!--


_______________________________________________
kde-docbook mailing list
kde-docbook@kde.org
https://mail.kde.org/mailman/listinfo/kde-docbook


[prev in list] [next in list] [prev in thread] [next in thread]