[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Re: KSocks on non-linux systems.
From:       David Faure <david () mandrakesoft ! com>
Date:       2001-03-20 16:09:30
[Download RAW message or body]

On Tuesday 20 March 2001 16:02, Rob Napier wrote:
> Is ksize_t certain to be compatible with socklen_t for platforms that
> have it? If so, then that's probably fine. If not, then you can't do
> it that way. The problem being solved is that on some platforms
> (linux) you need socklen_t, and on others (solaris) you need int or
> size_t depending on how XPG4 is set. ksize_t takes care of the
> int/size_t problem. This takes care of the socklen_t/ksize_t problem.

ksize_t gets defined to socklen_t where socklen_t is available.

> > BTW patching acconfig.h is always wrong, simply add the comment
> > in the AC_ method.
> 
> The point wasn't the comment. The point is the "undef" line (it's just
> traditional to comment these the way I did). I didn't patch the
> central acconfig.h. I created a local one for kdebase. autoconf will
> combine both together. This is required in order to use AC_CHECK_TYPE.

No it's not. Just like with any other check, either you need an acconfig.h
#undef line, or you need the comment in the AC_ line itself. Just look
at any other AC_ test and wonder why acconfig.h doesn't exist
up to now.
But this is OT, simply using ksize_t instead of socklen_t in the code will
fix it without the need for a new test.

-- 
David FAURE, david@mandrakesoft.com, faure@kde.org
http://perso.mandrakesoft.com/~david/, http://www.konqueror.org/
KDE, Making The Future of Computing Available Today

 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]