[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Re: KSocks on non-linux systems.
From:       Rob Napier <rnapier () employees ! org>
Date:       2001-03-20 16:02:54
[Download RAW message or body]

On Tue, Mar 20, 2001 at 02:28:26PM +0000, David Faure wrote:
> On Tuesday 20 March 2001 14:14, Rob Napier wrote:
> > Since George is out sick with work :) could someone apply this patch?
> > I've changed it as per Waldo's suggestion.
> >  
> > +AC_CHECK_TYPE(socklen_t,ksize_t)
> 
> What's this supposed to do ? We already define ksize_t ....

This defines socklen_t as ksize_t if socklen_t doesn't exist on this
platform (e.g. Solaris).


> It would be better to port the code so that it uses ksize_t.

Is ksize_t certain to be compatible with socklen_t for platforms that
have it? If so, then that's probably fine. If not, then you can't do
it that way. The problem being solved is that on some platforms
(linux) you need socklen_t, and on others (solaris) you need int or
size_t depending on how XPG4 is set. ksize_t takes care of the
int/size_t problem. This takes care of the socklen_t/ksize_t problem.


> BTW patching acconfig.h is always wrong, simply add the comment
> in the AC_ method.

The point wasn't the comment. The point is the "undef" line (it's just
traditional to comment these the way I did). I didn't patch the
central acconfig.h. I created a local one for kdebase. autoconf will
combine both together. This is required in order to use AC_CHECK_TYPE.

Rob
 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]