[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: PATCH: size of popup completion box
From:       David Smith <dsmith () algonet ! se>
Date:       2001-02-07 19:53:29
[Download RAW message or body]

Carsten Pfeiffer wrote:
> 
> On Wed, Feb 07, 2001 at 07:41:30PM +0100, David Smith wrote:
> 
> > Popup completion doesn't resize properly when the number of items
> > in the list increases while the list is open. With this patch the
> > size is adjusted each time popup() is called.
> > Can it be commited?
> 
> no, unfortunately this patch makes it rather unfriendly. It would
> basically resize on every keypress, which is really annoying (I had it
> that way in the very beginning and didn't like it at all).

And I thought that was an improvement :-)  Well, it doesn't matter,
just increasing the size when it is to small is good.
Take number two:

Index: kcompletionbox.cpp
===================================================================
RCS file: /home/kde/kdelibs/kdeui/kcompletionbox.cpp,v
retrieving revision 1.18
diff -u -r1.18 kcompletionbox.cpp
--- kcompletionbox.cpp  2001/01/03 21:04:14     1.18
+++ kcompletionbox.cpp  2001/02/07 19:51:35
@@ -165,6 +165,8 @@
         ensureCurrentVisible();
         if ( !isVisible() )
             show();
+        else if ( size().height() < sizeHint().height() )
+            resize( sizeHint() );
     }
 }


/David


> 
> The list would only enlarge when backspacing tho, right? Maybe we could
> only enlarge the box (i.e. by comparing current size and sizeHint) instead
> of always resizing?
>
 
>> Visit http://master.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread]