'Re: Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 125777: Monitor lib: Use Kformat::spelloutDuration to localize time string
From:       "Pinak Ahuja" <pinak.ahuja () gmail ! com>
Date:       2015-10-28 10:25:02
Message-ID: 20151028102502.14097.11932 () mimi ! kde ! org
[Download RAW message or body]

--===============1697866145647970705==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/125777/
-----------------------------------------------------------

(Updated Oct. 28, 2015, 10:25 a.m.)

Review request for Baloo and Vishesh Handa.

Changes
-------

Use the default locale set by KFormat's ctor, instead of setting it explicitly.

Repository: baloo

Description
-------

KFormat::spelloutDuration works perfectly well for out use case, using it is a no \
brainer.

Diffs (updated)
-----

  src/qml/experimental/CMakeLists.txt 0b06ac8 
  src/qml/experimental/monitor.cpp dfc7037 

Diff: https://git.reviewboard.kde.org/r/125777/diff/

Testing
-------

Thanks,

Pinak Ahuja

--===============1697866145647970705==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/125777/">https://git.reviewboard.kde.org/r/125777/</a>
  </td>
    </tr>
   </table>
   <br />

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo and Vishesh Handa.</div>
<div>By Pinak Ahuja.</div>

<p style="color: grey;"><i>Updated Oct. 28, 2015, 10:25 a.m.</i></p>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Changes</h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Use the default locale set by KFormat&#39;s ctor, instead of setting it \
explicitly.</pre>  </td>
 </tr>
</table>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;"><p style="padding: 0;text-rendering: inherit;margin: 0;line-height: \
inherit;white-space: inherit;">KFormat::spelloutDuration works perfectly well for out \
use case, using it is a no brainer.</p></pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> \
(updated)</h1> <ul style="margin-left: 3em; padding-left: 0;">

 <li>src/qml/experimental/CMakeLists.txt <span style="color: \
grey">(0b06ac8)</span></li>

 <li>src/qml/experimental/monitor.cpp <span style="color: grey">(dfc7037)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/125777/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1697866145647970705==--

[Attachment #3 (text/plain)]

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 