'Re: Review Request 121765: Fix build of metadatamovertest with clang'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 121765: Fix build of metadatamovertest with clang
From:       "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date:       2014-12-31 16:50:22
Message-ID: 20141231165022.18352.87458 () probe ! kde ! org
[Download RAW message or body]

--===============0889785722650514337==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121765/#review72851
-----------------------------------------------------------

Ship it!

Ship It!

- Raphael Kubo da Costa

On Dec. 31, 2014, 3:30 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121765/
> -----------------------------------------------------------
> 
> (Updated Dec. 31, 2014, 3:30 p.m.)
> 
> 
> Review request for Baloo.
> 
> 
> Repository: baloo
> 
> 
> Description
> -------
> 
> This tests compiles metadatamover.cpp again, but that is already contained
> in baloofilecommon which this test links to. This caused compilation to
> fail because of multiple definition of "vtable for MetaDataMover".
> 
> 
> Diffs
> -----
> 
> src/file/autotest/CMakeLists.txt 282eed43814eab4bffed58dc28667488482553bf 
> 
> Diff: https://git.reviewboard.kde.org/r/121765/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Richardson
> 
> 

--===============0889785722650514337==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121765/">https://git.reviewboard.kde.org/r/121765/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre>  <br />

<p>- Raphael Kubo da Costa</p>

<br />
<p>On December 31st, 2014, 3:30 p.m. EET, Alex Richardson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo.</div>
<div>By Alex Richardson.</div>

<p style="color: grey;"><i>Updated Dec. 31, 2014, 3:30 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">This tests compiles metadatamover.cpp again, but that is already \
contained in baloofilecommon which this test links to. This caused compilation to
fail because of multiple definition of &quot;vtable for MetaDataMover&quot;.</pre>
  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/file/autotest/CMakeLists.txt <span style="color: \
grey">(282eed43814eab4bffed58dc28667488482553bf)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121765/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============0889785722650514337==--

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 