From kde-devel Wed Dec 31 16:50:22 2014 From: "Raphael Kubo da Costa" Date: Wed, 31 Dec 2014 16:50:22 +0000 To: kde-devel Subject: Re: Review Request 121765: Fix build of metadatamovertest with clang Message-Id: <20141231165022.18352.87458 () probe ! kde ! org> X-MARC-Message: https://marc.info/?l=kde-devel&m=142004463404542 MIME-Version: 1 Content-Type: multipart/mixed; boundary="--===============0093682668841150955==" --===============0093682668841150955== Content-Type: multipart/alternative; boundary="===============0889785722650514337==" --===============0889785722650514337== MIME-Version: 1.0 Content-Type: text/plain; charset="utf-8" Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121765/#review72851 ----------------------------------------------------------- Ship it! Ship It! - Raphael Kubo da Costa On Dec. 31, 2014, 3:30 p.m., Alex Richardson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/121765/ > ----------------------------------------------------------- > > (Updated Dec. 31, 2014, 3:30 p.m.) > > > Review request for Baloo. > > > Repository: baloo > > > Description > ------- > > This tests compiles metadatamover.cpp again, but that is already contained > in baloofilecommon which this test links to. This caused compilation to > fail because of multiple definition of "vtable for MetaDataMover". > > > Diffs > ----- > > src/file/autotest/CMakeLists.txt 282eed43814eab4bffed58dc28667488482553bf > > Diff: https://git.reviewboard.kde.org/r/121765/diff/ > > > Testing > ------- > > > Thanks, > > Alex Richardson > > --===============0889785722650514337== MIME-Version: 1.0 Content-Type: text/html; charset="utf-8" Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/121765/

Ship it!

Ship It!

- Raphael Kubo da Costa

On December 31st, 2014, 3:30 p.m. EET, Alex Richardson wrote:

Review request for Baloo.

By Alex Richardson.

Updated Dec. 31, 2014, 3:30 p.m.

Repository: baloo

Description

This tests compiles metadatamover.cpp again, but that is already contained
in baloofilecommon which this test links to. This caused compilation to
fail because of multiple definition of "vtable for MetaDataMover".

Diffs

src/file/autotest/CMakeLists.txt (282eed43814eab4bffed58dc28667488482553bf)

View Diff

--===============0889785722650514337==-- --===============0093682668841150955== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============0093682668841150955==--