'Re: Review Request 121764: Fix build on FreeBSD'

[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: Review Request 121764: Fix build on FreeBSD
From:       "Raphael Kubo da Costa" <rakuco () FreeBSD ! org>
Date:       2014-12-31 16:48:26
Message-ID: 20141231164826.18352.64104 () probe ! kde ! org
[Download RAW message or body]

--===============1781670307961224831==
MIME-Version: 1.0
Content-Type: text/plain; charset="utf-8"
Content-Transfer-Encoding: 7bit

-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/121764/#review72850
-----------------------------------------------------------

Ship it!

Ship It!

- Raphael Kubo da Costa

On Dec. 30, 2014, 8:50 p.m., Alex Richardson wrote:
> 
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/121764/
> -----------------------------------------------------------
> 
> (Updated Dec. 30, 2014, 8:50 p.m.)
> 
> 
> Review request for Baloo and Raphael Kubo da Costa.
> 
> 
> Repository: kfilemetadata
> 
> 
> Description
> -------
> 
> ENODATA is not defined on FreeBSD. The Linux manpage says ENODATA is the
> same as ENOATTR, so it is safe to use that instead
> 
> 
> Diffs
> -----
> 
> src/usermetadata.cpp f2dd52ddc67fc6115c676b7af28a9764891f91c9 
> 
> Diff: https://git.reviewboard.kde.org/r/121764/diff/
> 
> 
> Testing
> -------
> 
> 
> Thanks,
> 
> Alex Richardson
> 
> 

--===============1781670307961224831==
MIME-Version: 1.0
Content-Type: text/html; charset="utf-8"
Content-Transfer-Encoding: 7bit

<html>
 <body>
  <div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
   <table bgcolor="#f9f3c9" width="100%" cellpadding="12" style="border: 1px #c9c399 \
solid; border-radius: 6px; -moz-border-radius: 6px; -webkit-border-radius: 6px;">  \
<tr>  <td>
      This is an automatically generated e-mail. To reply, visit:
      <a href="https://git.reviewboard.kde.org/r/121764/">https://git.reviewboard.kde.org/r/121764/</a>
  </td>
    </tr>
   </table>
   <br />

 <p>Ship it!</p>

 <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;"><p style="padding: \
0;text-rendering: inherit;margin: 0;line-height: inherit;white-space: inherit;">Ship \
It!</p></pre>  <br />

<p>- Raphael Kubo da Costa</p>

<br />
<p>On December 30th, 2014, 8:50 p.m. EET, Alex Richardson wrote:</p>

<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="12" style="border: \
1px #888a85 solid; border-radius: 6px; -moz-border-radius: 6px; \
-webkit-border-radius: 6px;">  <tr>
  <td>

<div>Review request for Baloo and Raphael Kubo da Costa.</div>
<div>By Alex Richardson.</div>

<p style="color: grey;"><i>Updated Dec. 30, 2014, 8:50 p.m.</i></p>

<div style="margin-top: 1.5em;">
 <b style="color: #575012; font-size: 10pt;">Repository: </b>
kfilemetadata
</div>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
 <table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0">  <tr>
  <td>
   <pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">ENODATA is not defined on FreeBSD. The Linux manpage says ENODATA is the \
same as ENOATTR, so it is safe to use that instead</pre>  </td>
 </tr>
</table>

<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">

 <li>src/usermetadata.cpp <span style="color: \
grey">(f2dd52ddc67fc6115c676b7af28a9764891f91c9)</span></li>

</ul>

<p><a href="https://git.reviewboard.kde.org/r/121764/diff/" style="margin-left: \
3em;">View Diff</a></p>

  </td>
 </tr>
</table>

  </div>
 </body>
</html>

--===============1781670307961224831==--

>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<

[prev in list] [next in list] [prev in thread] [next in thread] 