[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117845: rename test as another exists with the same name
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-04-29 12:56:33
Message-ID: 20140429125633.4809.45818 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
> On April 29, 2014, 10:53 a.m., Vishesh Handa wrote:
> > src/file/tests/CMakeLists.txt, line 30
> > <https://git.reviewboard.kde.org/r/117845/diff/2/?file=269061#file269061line30>
> >
> > I'm sorry. Could you do it the other way around?
> >
> > Keep the executable name - basicindexingqueuetest, and set the target name \
> > whatever you want?
> > Feel free to commit it after that.
>
> Patrick Spendrin wrote:
> Hm, that is original problem: then I have two executables of the same name, and on \
> windows they will be in the same directory (CMAKE_BINARY_DIR/bin) so overwriting \
> each other.
ah! Then just call it bindexingqueuetest.
You can remove the OUTPUT_NAME part also (if you want, I'm cool with both)
- Vishesh
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117845/#review56842
-----------------------------------------------------------
On April 29, 2014, 12:01 a.m., Patrick Spendrin wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117845/
> -----------------------------------------------------------
>
> (Updated April 29, 2014, 12:01 a.m.)
>
>
> Review request for Baloo and kdewin.
>
>
> Repository: baloo
>
>
> Description
> -------
>
> rename test as another exists with the same name
>
>
> Diffs
> -----
>
> src/file/tests/CMakeLists.txt 4f186483a9644d7b8de84335929cda16ceff71f3
>
> Diff: https://git.reviewboard.kde.org/r/117845/diff/
>
>
> Testing
> -------
>
> msvc 2010
>
>
> Thanks,
>
> Patrick Spendrin
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117845/">https://git.reviewboard.kde.org/r/117845/</a>
</td>
</tr>
</table>
<br />
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <p style="margin-top: 0;">On April 29th, 2014, 10:53 a.m. UTC, <b>Vishesh \
Handa</b> wrote:</p> <blockquote style="margin-left: 1em; border-left: 2px solid \
#d0d0d0; padding-left: 10px;">
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117845/diff/2/?file=269061#file269061line30" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/tests/CMakeLists.txt</a> <span style="font-weight: normal;">
(Diff revision 2)
</span>
</th>
</tr>
</thead>
<tbody>
<tr>
<th bgcolor="#e9eaa8" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2">30</font></th> <td bgcolor="#fdfebc" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="nb">set_target_properties</span><span class="p">(</span><span \
class="s">basicindexingqueuetest</span> <span class="s">PROPERTIES</span> <span \
class="s">COMPILE_FLAGS</span> <span class="s">-DBALOO_FILE_EXPORT=</span><span \
class="p">)</span></pre></td> <th bgcolor="#e9eaa8" style="border-left: 1px solid \
#C0C0C0; border-right: 1px solid #C0C0C0;" align="right"><font \
size="2">30</font></th> <td bgcolor="#fdfebc" width="50%"><pre style="font-size: \
8pt; line-height: 140%; margin: 0; "><span \
class="nb">set_target_properties</span><span class="p">(</span><span \
class="s">basicindexingqueuetest</span> <span class="s">PROPERTIES</span> <span \
class="s">COMPILE_FLAGS</span> <span class="s">-DBALOO_FILE_EXPORT=</span><span \
class="hl"> </span><span class="s"><span class="hl">OUTPUT_NAME</span></span><span \
class="hl"> </span><span class="s"><span \
class="hl">indexingqueuetest</span></span><span class="p">)</span></pre></td> </tr>
</tbody>
</table>
<pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I'm sorry. Could you \
do it the other way around?
Keep the executable name - basicindexingqueuetest, and set the target name whatever \
you want?
Feel free to commit it after that.</pre>
</blockquote>
<p>On April 29th, 2014, 11:03 a.m. UTC, <b>Patrick Spendrin</b> wrote:</p>
<blockquote style="margin-left: 1em; border-left: 2px solid #d0d0d0; padding-left: \
10px;"> <pre style="white-space: pre-wrap; white-space: -moz-pre-wrap; white-space: \
-pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Hm, that is original \
problem: then I have two executables of the same name, and on windows they will be in \
the same directory (CMAKE_BINARY_DIR/bin) so overwriting each other. </pre> \
</blockquote>
</blockquote>
<pre style="margin-left: 1em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">ah! Then \
just call it bindexingqueuetest.
You can remove the OUTPUT_NAME part also (if you want, I'm cool with both)</pre>
<br />
<p>- Vishesh</p>
<br />
<p>On April 29th, 2014, 12:01 a.m. UTC, Patrick Spendrin wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo and kdewin.</div>
<div>By Patrick Spendrin.</div>
<p style="color: grey;"><i>Updated April 29, 2014, 12:01 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">rename test as another exists with the same name</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">msvc 2010</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/tests/CMakeLists.txt <span style="color: \
grey">(4f186483a9644d7b8de84335929cda16ceff71f3)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117845/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic