--===============5276257839815849197== Content-Type: multipart/alternative; boundary="===============1844133383718077969==" --===============1844133383718077969== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit > On April 29, 2014, 10:53 a.m., Vishesh Handa wrote: > > src/file/tests/CMakeLists.txt, line 30 > > > > > > I'm sorry. Could you do it the other way around? > > > > Keep the executable name - basicindexingqueuetest, and set the target name whatever you want? > > > > Feel free to commit it after that. > > Patrick Spendrin wrote: > Hm, that is original problem: then I have two executables of the same name, and on windows they will be in the same directory (CMAKE_BINARY_DIR/bin) so overwriting each other. ah! Then just call it bindexingqueuetest. You can remove the OUTPUT_NAME part also (if you want, I'm cool with both) - Vishesh ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117845/#review56842 ----------------------------------------------------------- On April 29, 2014, 12:01 a.m., Patrick Spendrin wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117845/ > ----------------------------------------------------------- > > (Updated April 29, 2014, 12:01 a.m.) > > > Review request for Baloo and kdewin. > > > Repository: baloo > > > Description > ------- > > rename test as another exists with the same name > > > Diffs > ----- > > src/file/tests/CMakeLists.txt 4f186483a9644d7b8de84335929cda16ceff71f3 > > Diff: https://git.reviewboard.kde.org/r/117845/diff/ > > > Testing > ------- > > msvc 2010 > > > Thanks, > > Patrick Spendrin > > --===============1844133383718077969== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117845/

On April 29th, 2014, 10:53 a.m. UTC, Vishesh Handa wrote:

src/file/tests/CMakeLists.txt (Diff revision 2)

30

set_target_properties(basicindexingqueuetest PROPERTIES COMPILE_FLAGS -DBALOO_FILE_EXPORT=)

30

set_target_properties(basicindexingqueuetest PROPERTIES COMPILE_FLAGS -DBALOO_FILE_EXPORT= OUTPUT_NAME indexingqueuetest)

I'm sorry. Could you do it the other way around?

Keep the executable name - basicindexingqueuetest, and set the target name whatever you want?

Feel free to commit it after that.

On April 29th, 2014, 11:03 a.m. UTC, Patrick Spendrin wrote:

Hm, that is original problem: then I have two executables of the same name, and on windows they will be in the same directory (CMAKE_BINARY_DIR/bin) so overwriting each other.

ah! Then just call it bindexingqueuetest.

You can remove the OUTPUT_NAME part also (if you want, I'm cool with both)

- Vishesh

On April 29th, 2014, 12:01 a.m. UTC, Patrick Spendrin wrote:

Review request for Baloo and kdewin.

By Patrick Spendrin.

Updated April 29, 2014, 12:01 a.m.

Repository: baloo

Description

rename test as another exists with the same name

Testing

msvc 2010

Diffs

src/file/tests/CMakeLists.txt (4f186483a9644d7b8de84335929cda16ceff71f3)

--===============1844133383718077969==-- --===============5276257839815849197== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============5276257839815849197==--