[prev in list] [next in list] [prev in thread] [next in thread]
List: kde-devel
Subject: Re: Review Request 117420: Fixes issue with full path of excluded directory not being shown
From: "Vishesh Handa" <me () vhanda ! in>
Date: 2014-04-12 18:00:06
Message-ID: 20140412180006.22681.93079 () probe ! kde ! org
[Download RAW message or body]
[Attachment #2 (multipart/alternative)]
-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://git.reviewboard.kde.org/r/117420/#review55527
-----------------------------------------------------------
src/file/kcm/folderselectionwidget.cpp
<https://git.reviewboard.kde.org/r/117420/#comment38637>
Could you please also add a 'const' over here.
src/file/kcm/folderselectionwidget.cpp
<https://git.reviewboard.kde.org/r/117420/#comment38636>
I've given this more thought, and I dislike the '~/'. Please remove it.
The rest is fine.
I can ask for an exception from the release team and ship this with 4.13
- Vishesh Handa
On April 8, 2014, 11:52 a.m., Lindsay Mathieson wrote:
>
> -----------------------------------------------------------
> This is an automatically generated e-mail. To reply, visit:
> https://git.reviewboard.kde.org/r/117420/
> -----------------------------------------------------------
>
> (Updated April 8, 2014, 11:52 a.m.)
>
>
> Review request for Baloo.
>
>
> Bugs: 333155
> http://bugs.kde.org/show_bug.cgi?id=333155
>
>
> Repository: baloo
>
>
> Description
> -------
>
> Displays full path of excluded directories - reduce possibilities of confusion and ambiguity.
>
>
> Diffs
> -----
>
> src/file/kcm/folderselectionwidget.h 5e4e661
> src/file/kcm/folderselectionwidget.cpp bc87a33
>
> Diff: https://git.reviewboard.kde.org/r/117420/diff/
>
>
> Testing
> -------
>
> Build, installed - opens KCM module, full paths displayed, with ample room.
>
>
> Thanks,
>
> Lindsay Mathieson
>
>
[Attachment #5 (text/html)]
<html>
<body>
<div style="font-family: Verdana, Arial, Helvetica, Sans-Serif;">
<table bgcolor="#f9f3c9" width="100%" cellpadding="8" style="border: 1px #c9c399 \
solid;"> <tr>
<td>
This is an automatically generated e-mail. To reply, visit:
<a href="https://git.reviewboard.kde.org/r/117420/">https://git.reviewboard.kde.org/r/117420/</a>
</td>
</tr>
</table>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117420/diff/2-3/?file=263314#file263314line291" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/kcm/folderselectionwidget.cpp</a> <span style="font-weight: \
normal;">
(Diff revisions 2 - 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
FolderSelectionWidget::showMessage(const QString& message)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">291</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "><span \
class="n">QString</span> <span class="n">FolderSelectionWidget</span><span \
class="o">::</span><span class="n">getFolderDisplayName</span><span \
class="p">(</span><span class="k">const</span> <span class="n">QString</span><span \
class="o">&</span> <span class="n">url</span><span class="p">)</span></pre></td> \
</tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">Could you \
please also add a 'const' over here.</pre> </div>
<br />
<div>
<table width="100%" border="0" bgcolor="white" style="border: 1px solid #C0C0C0; \
border-collapse: collapse; margin: 2px padding: 2px;"> <thead>
<tr>
<th colspan="4" bgcolor="#F0F0F0" style="border-bottom: 1px solid #C0C0C0; \
font-size: 9pt; padding: 4px 8px; text-align: left;"> <a \
href="https://git.reviewboard.kde.org/r/117420/diff/2-3/?file=263314#file263314line295" \
style="color: black; font-weight: bold; text-decoration: \
underline;">src/file/kcm/folderselectionwidget.cpp</a> <span style="font-weight: \
normal;">
(Diff revisions 2 - 3)
</span>
</th>
</tr>
</thead>
<tbody style="background-color: #e4d9cb; padding: 4px 8px; text-align: center;">
<tr>
<td colspan="4"><pre style="font-size: 8pt; line-height: 140%; margin: 0; ">void \
FolderSelectionWidget::showMessage(const QString& message)</pre></td>
</tr>
</tbody>
<tbody>
<tr>
<th bgcolor="#b1ebb0" style="border-right: 1px solid #C0C0C0;" \
align="right"><font size="2"></font></th> <td bgcolor="#c5ffc4" width="50%"><pre \
style="font-size: 8pt; line-height: 140%; margin: 0; "></pre></td> <th \
bgcolor="#b1ebb0" style="border-left: 1px solid #C0C0C0; border-right: 1px solid \
#C0C0C0;" align="right"><font size="2">295</font></th> <td bgcolor="#c5ffc4" \
width="50%"><pre style="font-size: 8pt; line-height: 140%; margin: 0; "> <span \
class="k">return</span> <span class="s">"[~]/"</span> <span \
class="o">+</span> <span class="n">url</span><span class="p">.</span><span \
class="n">mid</span><span class="p">(</span><span class="n">QDir</span><span \
class="o">::</span><span class="n">homePath</span><span class="p">().</span><span \
class="n">length</span><span class="p">()</span> <span class="o">+</span> <span \
class="mi">1</span><span class="p">);</span></pre></td> </tr>
</tbody>
</table>
<pre style="margin-left: 2em; white-space: pre-wrap; white-space: -moz-pre-wrap; \
white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: break-word;">I've \
given this more thought, and I dislike the '~/'. Please remove it.
The rest is fine.
I can ask for an exception from the release team and ship this with 4.13</pre>
</div>
<br />
<p>- Vishesh Handa</p>
<br />
<p>On April 8th, 2014, 11:52 a.m. UTC, Lindsay Mathieson wrote:</p>
<table bgcolor="#fefadf" width="100%" cellspacing="0" cellpadding="8" \
style="background-image: \
url('https://git.reviewboard.kde.org/static/rb/images/review_request_box_top_bg.ab6f3b1072c9.png'); \
background-position: left top; background-repeat: repeat-x; border: 1px black \
solid;"> <tr>
<td>
<div>Review request for Baloo.</div>
<div>By Lindsay Mathieson.</div>
<p style="color: grey;"><i>Updated April 8, 2014, 11:52 a.m.</i></p>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Bugs: </b>
<a href="http://bugs.kde.org/show_bug.cgi?id=333155">333155</a>
</div>
<div style="margin-top: 1.5em;">
<b style="color: #575012; font-size: 10pt;">Repository: </b>
baloo
</div>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Description </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" \
style="border: 1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Displays full path of excluded directories - reduce possibilities of \
confusion and ambiguity.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Testing </h1>
<table width="100%" bgcolor="#ffffff" cellspacing="0" cellpadding="10" style="border: \
1px solid #b8b5a0"> <tr>
<td>
<pre style="margin: 0; padding: 0; white-space: pre-wrap; white-space: \
-moz-pre-wrap; white-space: -pre-wrap; white-space: -o-pre-wrap; word-wrap: \
break-word;">Build, installed - opens KCM module, full paths displayed, with ample \
room.</pre> </td>
</tr>
</table>
<h1 style="color: #575012; font-size: 10pt; margin-top: 1.5em;">Diffs</b> </h1>
<ul style="margin-left: 3em; padding-left: 0;">
<li>src/file/kcm/folderselectionwidget.h <span style="color: \
grey">(5e4e661)</span></li>
<li>src/file/kcm/folderselectionwidget.cpp <span style="color: \
grey">(bc87a33)</span></li>
</ul>
<p><a href="https://git.reviewboard.kde.org/r/117420/diff/" style="margin-left: \
3em;">View Diff</a></p>
</td>
</tr>
</table>
</div>
</body>
</html>
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]
Configure |
About |
News |
Add a list |
Sponsored by KoreLogic