--===============3486800691299781128== Content-Type: multipart/alternative; boundary="===============3431339997620263272==" --===============3431339997620263272== Content-Type: text/plain; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit ----------------------------------------------------------- This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117420/#review55527 ----------------------------------------------------------- src/file/kcm/folderselectionwidget.cpp Could you please also add a 'const' over here. src/file/kcm/folderselectionwidget.cpp I've given this more thought, and I dislike the '~/'. Please remove it. The rest is fine. I can ask for an exception from the release team and ship this with 4.13 - Vishesh Handa On April 8, 2014, 11:52 a.m., Lindsay Mathieson wrote: > > ----------------------------------------------------------- > This is an automatically generated e-mail. To reply, visit: > https://git.reviewboard.kde.org/r/117420/ > ----------------------------------------------------------- > > (Updated April 8, 2014, 11:52 a.m.) > > > Review request for Baloo. > > > Bugs: 333155 > http://bugs.kde.org/show_bug.cgi?id=333155 > > > Repository: baloo > > > Description > ------- > > Displays full path of excluded directories - reduce possibilities of confusion and ambiguity. > > > Diffs > ----- > > src/file/kcm/folderselectionwidget.h 5e4e661 > src/file/kcm/folderselectionwidget.cpp bc87a33 > > Diff: https://git.reviewboard.kde.org/r/117420/diff/ > > > Testing > ------- > > Build, installed - opens KCM module, full paths displayed, with ample room. > > > Thanks, > > Lindsay Mathieson > > --===============3431339997620263272== Content-Type: text/html; charset="utf-8" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit

This is an automatically generated e-mail. To reply, visit: https://git.reviewboard.kde.org/r/117420/

src/file/kcm/folderselectionwidget.cpp (Diff revisions 2 - 3)
void FolderSelectionWidget::showMessage(const QString& message)
		291	QString FolderSelectionWidget::getFolderDisplayName(const QString& url)

Could you please also add a 'const' over here.

src/file/kcm/folderselectionwidget.cpp (Diff revisions 2 - 3)
void FolderSelectionWidget::showMessage(const QString& message)
		295	return "[~]/" + url.mid(QDir::homePath().length() + 1);

I've given this more thought, and I dislike the '~/'. Please remove it.

The rest is fine.

I can ask for an exception from the release team and ship this with 4.13

- Vishesh Handa

On April 8th, 2014, 11:52 a.m. UTC, Lindsay Mathieson wrote:

Review request for Baloo.

By Lindsay Mathieson.

Updated April 8, 2014, 11:52 a.m.

Bugs: 333155

Repository: baloo

Description

Displays full path of excluded directories - reduce possibilities of confusion and ambiguity.

Testing

Build, installed - opens KCM module, full paths displayed, with ample room.

Diffs

src/file/kcm/folderselectionwidget.h (5e4e661)
src/file/kcm/folderselectionwidget.cpp (bc87a33)

--===============3431339997620263272==-- --===============3486800691299781128== Content-Type: text/plain; charset="us-ascii" MIME-Version: 1.0 Content-Transfer-Encoding: 7bit Content-Disposition: inline >> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe << --===============3486800691299781128==--