[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Konsole private library
From:       Pau Garcia i Quiles <pgquiles () elpauer ! org>
Date:       2009-02-02 12:29:41
Message-ID: 3af572ac0902020429y56a3fdb2ta4188521930f8c40 () mail ! gmail ! com
[Download RAW message or body]

On Mon, Feb 2, 2009 at 1:20 PM, Patrick Spendrin <ps_ml@gmx.de> wrote:
> Thiago Macieira schrieb:
>> Patrick Spendrin wrote:
>>> Hi,
>>>
>>> as I am currently porting Konsole to Windows, I need to change the
>>> exports a bit. As this is a rather big change, I'd prefer to get some
>>> more review of the patch here (I already asked in konsole-devel@).
>>>
>>> So please take the time to both take a look at the patch itself and try
>>> to compile & test it.
>>>
>>> If nobody objects, I would commit the patch in the coming days.
>>
>> There's one thing missing in your message and the patch: why?
>>
>> Why is it necessary to have a private library?
> Ah, there are two good reasons for it:
> 1) For the konsole part all files get recompiled (at least here) as
> there is a new compile flags set (-DKONSOLE_PART).
> 2) on windows I can't link to the kdeinit_executable as this is no
> library. Until now there are simple KDE_EXPORTs done in the code, which
> do not work here; I want to make the patches work though, so it is
> easiest to use a "private" library as in kmail and some others for that.

It is possible to link to an executable:
http://article.gmane.org/gmane.comp.programming.tools.cmake.user/18735


-- 
Pau Garcia i Quiles
http://www.elpauer.org
(Due to my workload, I may need 10 days to answer)
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]