[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: [PATCH] Konsole private library
From:       Patrick Spendrin <ps_ml () gmx ! de>
Date:       2009-02-02 12:20:05
Message-ID: 4986E4F5.7060601 () gmx ! de
[Download RAW message or body]

Thiago Macieira schrieb:
> Patrick Spendrin wrote:
>> Hi,
>>
>> as I am currently porting Konsole to Windows, I need to change the
>> exports a bit. As this is a rather big change, I'd prefer to get some
>> more review of the patch here (I already asked in konsole-devel@).
>>
>> So please take the time to both take a look at the patch itself and try
>> to compile & test it.
>>
>> If nobody objects, I would commit the patch in the coming days.
> 
> There's one thing missing in your message and the patch: why?
> 
> Why is it necessary to have a private library?
Ah, there are two good reasons for it:
1) For the konsole part all files get recompiled (at least here) as 
there is a new compile flags set (-DKONSOLE_PART).
2) on windows I can't link to the kdeinit_executable as this is no 
library. Until now there are simple KDE_EXPORTs done in the code, which 
do not work here; I want to make the patches work though, so it is 
easiest to use a "private" library as in kmail and some others for that.
> 
regards,
Patrick

-- 
web:                 http://windows.kde.org
mailing list:        kde-windows@kde.org
irc:                 #kde-windows (irc.freenode.net)
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]