[prev in list] [next in list] [prev in thread] [next in thread] 

List:       kde-devel
Subject:    Re: resurrecting kwrited
From:       Oswald Buddenhagen <ossi () kde ! org>
Date:       2008-10-17 13:19:19
Message-ID: 20081017131919.GA23171 () troll08
[Download RAW message or body]

On Tue, Oct 14, 2008 at 02:16:12PM +0300, George Kiagiadakis wrote:
> 2008/10/13 Oswald Buddenhagen <ossi@kde.org>:
> >> Also, this slotData() doesn't do anything different, it just uses
> >> read(2) to read data into a buffer.
> >>
> > ****** huh?
> 
whoops, that was a marker for later, which i forgot ...

> I think I get the point now,
>
i don't think so ...
the whole "common mistake" paragraph is about avoiding potentially
butchering utf8 sequences. your code (and the old one, of course)
thoroughly ignores the problem. of course this is totally marginal and
likely without real-world effect in this case, but code is copied, so it
should be correct everywhere.

> Tell me if I need to fix something else.
>
nothing obvious. in any case, you are the kwrited maintainer now. get
yourself an svn account to fulfill that role. :D

> Btw, does anybody have an idea what those items in the TODO comment in
> kwrited.cpp mean? I think they are pretty useless...
>
yes, bitrot. trash it.
some of these points refer to persistence of some kind, which becomes
irrelevant after the knotify move. anyway, does knotify provide some
persistence mechanisms? like, a message box being restored with the
session? passive popups not going away when the machine is idle (e.g.,
per screensaver interface)?

-- 
Hi! I'm a .signature virus! Copy me into your ~/.signature, please!
--
Confusion, chaos, panic - my work here is done.
 
>> Visit http://mail.kde.org/mailman/listinfo/kde-devel#unsub to unsubscribe <<
[prev in list] [next in list] [prev in thread] [next in thread]